Skip to contentSkip to conversation

patch "usb: udc: core: add device_del() call to error pathway" added to usb-linus

PATCH [email protected] 1 participant 1 message Aug 3, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: udc: core: add device_del() call to error pathway

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From c93e64e91248becd0edb8f01723dff9da890e2ab Mon Sep 17 00:00:00 2001

From: Alan Stern <[email protected]>
Date: Fri, 16 Jan 2015 11:32:51 -0500
Subject: usb: udc: core: add device_del() call to error pathway

This patch fixes a bug in the error pathway of usb_add_gadget_udc_release() in udc-core.c. If the udc registration fails, the gadget registration is not fully undone; there's a put_device(&gadget->dev) call but no device_del().

---
 drivers/usb/gadget/udc/udc-core.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/gadget/udc/udc-core.c +1 -0
index 362ee8af5fce..89ed5e71a199 100644
@@ -323,6 +323,7 @@ err4:
 
 err3:
 	put_device(&udc->dev);
+	device_del(&gadget->dev);
 
 err2:
 	put_device(&gadget->dev);
Signature · 1 line
2.5.0