Skip to contentSkip to conversation

sched/deadline: fix comment in push_dl_tasks

PATCH In review Andrea Parri 3 participants 6 messages Aug 5, 2015 – Aug 12, 2015 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 sched/deadline: fix comment in push_dl_tasks

The comment is "misleading"; fix it by adapting a comment from push_rt_tasks.

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +1 -1
index 0a17af35..7c17001 100644
@@ -1563,7 +1563,7 @@ out:
 
 static void push_dl_tasks(struct rq *rq)
 {
-	/* Terminates as it moves a -deadline task */
+	/* push_dl_task will return true if it moved a -deadline task */
 	while (push_dl_task(rq))
 		;
 }
Signature · 1 line
1.9.1
#1 lore raw

PATCH 2/2 sched/deadline: fix comment in enqueue_task_dl

The flag "dl_boosted" is set by comparing *absolute* deadlines (c.f., rt_mutex_setprio).

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +1 -1
index 7c17001..be2ca5e 100644
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 
 	/*
 	 * Use the scheduling parameters of the top pi-waiter
-	 * task if we have one and its (relative) deadline is
+	 * task if we have one and its (absolute) deadline is
 	 * smaller than our one... OTW we keep our runtime and
 	 * deadline.
 	 */
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH 2/2] sched/deadline: fix comment in enqueue_task_dl

Hi,

Quoted 14 lines · Andrea Parri

The flag "dl_boosted" is set by comparing *absolute* deadlines (c.f., rt_mutex_setprio).

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +0 -0
index 7c17001..be2ca5e 100644

kernel/sched/deadline.c static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags) · line 959

Quoted 8 lines
kernel/sched/deadline.c +1 -1
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 
 	/*
 	 * Use the scheduling parameters of the top pi-waiter
-	 * task if we have one and its (relative) deadline is
+	 * task if we have one and its (absolute) deadline is
 	 * smaller than our one... OTW we keep our runtime and
 	 * deadline.
 	 */

Right, thanks for spotting it.

Best,

- Juri

#3 lore raw

[tip:sched/core] sched/deadline: Fix comment in enqueue_task_dl()

In reply to Andrea Parri
sched/deadline: Fix comment in enqueue_task_dl()
Commit-ID:  ff277d4250fe715b6666219b1a3423b863418794
Gitweb:     http://git.kernel.org/tip/ff277d4250fe715b6666219b1a3423b863418794
Author:     Andrea Parri <[email protected]>
AuthorDate: Wed, 5 Aug 2015 15:56:19 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200

sched/deadline: Fix comment in enqueue_task_dl()

The "dl_boosted" flag is set by comparing *absolute* deadlines (c.f., rt_mutex_setprio()).

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +1 -1
index 82c0dd0..fc8f010 100644
@@ -953,7 +953,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 
 	/*
 	 * Use the scheduling parameters of the top pi-waiter
-	 * task if we have one and its (relative) deadline is
+	 * task if we have one and its (absolute) deadline is
 	 * smaller than our one... OTW we keep our runtime and
 	 * deadline.
 	 */
#4 lore raw
In reply to Andrea Parri

Hi Andrea,

Quoted 14 lines · Andrea Parri

The comment is "misleading"; fix it by adapting a comment from push_rt_tasks.

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +0 -0
index 0a17af35..7c17001 100644

kernel/sched/deadline.c out: · line 1569

Quoted 8 lines
kernel/sched/deadline.c +1 -1
@@ -1563,7 +1563,7 @@ out:
 
 static void push_dl_tasks(struct rq *rq)
 {
-	/* Terminates as it moves a -deadline task */
+	/* push_dl_task will return true if it moved a -deadline task */
 	while (push_dl_task(rq))
 		;
 }

Looks good, thanks!

Best,

- Juri

#5 lore raw

[tip:sched/core] sched/deadline: Fix comment in push_dl_tasks()

In reply to Andrea Parri
sched/deadline: Fix comment in push_dl_tasks()
Commit-ID:  4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Gitweb:     http://git.kernel.org/tip/4ffa08ed4cc4c5d47d197d749aae6f79af91eb73
Author:     Andrea Parri <[email protected]>
AuthorDate: Wed, 5 Aug 2015 15:56:18 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Aug 2015 12:06:10 +0200

sched/deadline: Fix comment in push_dl_tasks()

The comment is "misleading"; fix it by adapting a comment from push_rt_tasks().

---
 kernel/sched/deadline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/deadline.c +1 -1
index b473056..82c0dd0 100644
@@ -1563,7 +1563,7 @@ out:
 
 static void push_dl_tasks(struct rq *rq)
 {
-	/* Terminates as it moves a -deadline task */
+	/* push_dl_task() will return true if it moved a -deadline task */
 	while (push_dl_task(rq))
 		;
 }