regamp: debugfs: Fix misuse of IS_ENABLED
Subsystems (2)
PATCH 1/1 regamp: debugfs: Fix misuse of IS_ENABLED
IS_ENABLED should only be used for CONFIG_* symbols.
I have done a small test:
#define REGMAP_ALLOW_WRITE_DEBUGFS IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0.
#define REGMAP_ALLOW_WRITE_DEBUGFS 0 IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0. #define REGMAP_ALLOW_WRITE_DEBUGFS 1 IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 1. #define REGMAP_ALLOW_WRITE_DEBUGFS 2 IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) returns 0.
So fix the misuse of IS_ENABLED(REGMAP_ALLOW_WRITE_DEBUGFS) and switch to use #if defined(REGMAP_ALLOW_WRITE_DEBUGFS) instead.
Signed-off-by Axel Lin <[email protected]>
--- drivers/base/regmap/regmap-debugfs.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/base/regmap/regmap-debugfs.c +5 -4
@@ -599,10 +599,11 @@ void regmap_debugfs_init(struct regmap *map, const char *name)if (map->max_register ||regmap_readable (map,0 )) {umode_t registers_mode; -if (IS_ENABLED (REGMAP_ALLOW_WRITE_DEBUGFS )) - registers_mode =0600 ; -else - registers_mode =0400 ; +#if defined(REGMAP_ALLOW_WRITE_DEBUGFS ) + registers_mode =0600 ; +#else + registers_mode =0400 ; +#endif debugfs_create_file ("registers" , registers_mode, map->debugfs, map, ®map_map_fops);
Signature · 1 line
2.1.0