Skip to contentSkip to conversation

drm/i915: Spam less on dp aux send/receive problems

PATCH In review Mika Kuoppala 4 participants 6 messages Aug 6, 2015 – Aug 13, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Spam less on dp aux send/receive problems

If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status.

Inject a new backtrace only if we have new information to share as otherwise we flush out all other important stuff.

---
 drivers/gpu/drm/i915/intel_dp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +9 -2
index df7e2cf..6b2f7af 100644
@@ -849,8 +849,15 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 	}
 
 	if (try == 3) {
-		WARN(1, "dp_aux_ch not started status 0x%08x\n",
-		     I915_READ(ch_ctl));
+		static u32 last_status = -1;
+		const u32 status = I915_READ(ch_ctl);
+
+		if (status != last_status) {
+			WARN(1, "dp_aux_ch not started status 0x%08x\n",
+			     status);
+			last_status = status;
+		}
+
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#1 lore raw
Quoted 22 lines · Mika Kuoppala

If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status.

Inject a new backtrace only if we have new information to share as otherwise we flush out all other important stuff.

---
 drivers/gpu/drm/i915/intel_dp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -1
index df7e2cf..6b2f7af 100644
@@ -849,8 +849,15 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 	}
 
 	if (try == 3) {
-		WARN(1, "dp_aux_ch not started status 0x%08x\n",

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_ch(struct intel_dp *intel_dp, · line 860

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +9 -1
-		     I915_READ(ch_ctl));
+		static u32 last_status = -1;
+		const u32 status = I915_READ(ch_ctl);
+
+		if (status != last_status) {
+			WARN(1, "dp_aux_ch not started status 0x%08x\n",
+			     status);
+			last_status = status;
+		}
+

But now you'll also skip the logging even if there's been a day and a million successful transfers since the last error... I understand your concern, but if you feel you must do something like this, please at least reset last_status on success.

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0 -0
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#2 lore raw
Quoted 30 lines · Jani Nikula
Quoted 29 lines · Mika Kuoppala

If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status.

Inject a new backtrace only if we have new information to share as otherwise we flush out all other important stuff.

---
 drivers/gpu/drm/i915/intel_dp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +6 -2
index df7e2cf..6b2f7af 100644
@@ -849,8 +849,15 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 	}
 
 	if (try == 3) {
-		WARN(1, "dp_aux_ch not started status 0x%08x\n",
-		     I915_READ(ch_ctl));
+		static u32 last_status = -1;
+		const u32 status = I915_READ(ch_ctl);
+
+		if (status != last_status) {
+			WARN(1, "dp_aux_ch not started status 0x%08x\n",
+			     status);
Quoted 8 lines

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_ch(struct intel_dp *intel_dp, · line 860

Quoted 3 lines
drivers/gpu/drm/i915/intel_dp.c +3 -0
+			last_status = status;
+		}
+

But now you'll also skip the logging even if there's been a day and a million successful transfers since the last error... I understand your concern, but if you feel you must do something like this, please at least reset last_status on success.

Hmh, I see now that this has already been merged... :(

Quoted 18 lines

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0 -0
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 40 lines · Jani Nikula
Quoted 30 lines · Jani Nikula
Quoted 29 lines · Mika Kuoppala

If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status.

Inject a new backtrace only if we have new information to share as otherwise we flush out all other important stuff.

---
 drivers/gpu/drm/i915/intel_dp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +6 -2
index df7e2cf..6b2f7af 100644
@@ -849,8 +849,15 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 	}
 
 	if (try == 3) {
-		WARN(1, "dp_aux_ch not started status 0x%08x\n",
-		     I915_READ(ch_ctl));
+		static u32 last_status = -1;
+		const u32 status = I915_READ(ch_ctl);
+
+		if (status != last_status) {
+			WARN(1, "dp_aux_ch not started status 0x%08x\n",
+			     status);
Quoted 8 lines

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_ch(struct intel_dp *intel_dp, · line 860

Quoted 3 lines
drivers/gpu/drm/i915/intel_dp.c +3 -0
+			last_status = status;
+		}
+

But now you'll also skip the logging even if there's been a day and a million successful transfers since the last error... I understand your concern, but if you feel you must do something like this, please at least reset last_status on success.

Quoted 1 line

Hmh, I see now that this has already been merged... :(

Well I like the idea, Mika please supply a fixup patch. -Daniel

Quoted 27 lines
Quoted 20 lines

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0 -0
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 41 lines · Daniel Vetter
Quoted 40 lines · Jani Nikula
Quoted 38 lines · Jani Nikula
Quoted 22 lines · Mika Kuoppala

If we encounter frequent problems with dp aux channel communications, we end up spamming the dmesg with the exact similar trace and status.

Inject a new backtrace only if we have new information to share as otherwise we flush out all other important stuff.

---
 drivers/gpu/drm/i915/intel_dp.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_dp.c +0 -1
index df7e2cf..6b2f7af 100644
@@ -849,8 +849,15 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
 	}
 
 	if (try == 3) {
-		WARN(1, "dp_aux_ch not started status 0x%08x\n",

drivers/gpu/drm/i915/intel_dp.c intel_dp_aux_ch(struct intel_dp *intel_dp, · line 860

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +9 -1
-		     I915_READ(ch_ctl));
+		static u32 last_status = -1;
+		const u32 status = I915_READ(ch_ctl);
+
+		if (status != last_status) {
+			WARN(1, "dp_aux_ch not started status 0x%08x\n",
+			     status);
+			last_status = status;
+		}
+

But now you'll also skip the logging even if there's been a day and a million successful transfers since the last error... I understand your concern, but if you feel you must do something like this, please at least reset last_status on success.

Quoted 3 lines
Quoted 1 line

Hmh, I see now that this has already been merged... :(

Well I like the idea, Mika please supply a fixup patch.

I have a fixup to clear the last status on success.

And I also patch which get rids of the trickery and then just WARN_ON_ONCE if try == 3, suggested by Jani.

As this was just in a way of skl debugging by flooding logs, both approaches are fine with. What is the preferred approach for the display devs?

-Mika

Quoted 23 lines

-Daniel

Quoted 21 lines
Quoted 20 lines

BR,
Jani.

Quoted 10 lines
drivers/gpu/drm/i915/intel_dp.c +0 -0
 		ret = -EBUSY;
 		goto out;
 	}
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 11 lines
Quoted 6 lines
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Tested-by on v1 1/1
#5 lore raw
In reply to Mika Kuoppala

Task id: 7106 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied

ILK                                  302/302              302/302
SNB                                  315/315              315/315
IVB                                  336/336              336/336

BYT -1 283/283 282/283
HSW 378/378 378/378
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*BYT igt@gem_partial_pwrite_pread@reads-uncached PASS(1) FAIL(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx