ARCv2: spinlock/rwlock/atomics: reduce 1 instruction in exponential backoff
Subsystems (3)
PATCH 1/1 ARCv2: spinlock/rwlock/atomics: reduce 1 instruction in exponential backoff
The increment of delay counter was 2 instructions:
Arithmatic Shfit Left (ASL) + set to 1 on overflow
This can be done in 1 using ROtate Left (ROL)
Suggested-by Nigel Topham <[email protected]>
Cc Peter Zijlstra (Intel) <[email protected]>
Signed-off-by Vineet Gupta <[email protected]>
--- arch/arc/include/asm/atomic.h | 3 +-- arch/arc/include/asm/spinlock.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-)
arch/arc/include/asm/atomic.h +1 -2
@@ -34,8 +34,7 @@" mov %[tmp], %[delay] \n" /* tmp = delay */ \"2: brne.d %[tmp], 0, 2b \n" /* while (tmp != 0) */ \" sub %[tmp], %[tmp], 1 \n" /* tmp-- */ \ -" asl.f %[delay], %[delay], 1 \n" /* delay *= 2 */ \ -" mov.z %[delay], 1 \n" /* handle overflow */ \ +" rol %[delay], %[delay] \n" /* delay *= 2 */ \" b 1b \n" /* start over */ \"4: ; --- success --- \n" \
arch/arc/include/asm/spinlock.h +1 -2
@@ -260,8 +260,7 @@ static inline void arch_write_unlock(arch_rwlock_t *rw)" mov %[tmp], %[delay] \n" /* tmp = delay */ \"2: brne.d %[tmp], 0, 2b \n" /* while (tmp != 0) */ \" sub %[tmp], %[tmp], 1 \n" /* tmp-- */ \ -" asl.f %[delay], %[delay], 1 \n" /* delay *= 2 */ \ -" mov.z %[delay], 1 \n" /* handle overflow */ \ +" rol %[delay], %[delay] \n" /* delay *= 2 */ \" b 1b \n" /* start over */ \" \n" \"4: ; --- done --- \n" \
Signature · 1 line
1.9.1
Peter Zijlstra
maintainerQuoted 4 lines · Vineet Gupta
The increment of delay counter was 2 instructions:
Arithmatic Shfit Left (ASL) + set to 1 on overflowThis can be done in 1 using ROtate Left (ROL)
Cute :-)