Skip to contentSkip to conversation

perf, tools: Support static linking with libdw

PATCH Applied Andi Kleen 3 participants 5 messages Aug 7, 2015 – Aug 10, 2015 perf events

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, tools: Support static linking with libdw

From: Andi Kleen <[email protected]>

The Fedora 22 version of libdw requires a couple of extra libraries to link. With a dynamic link the dependencies are pulled in automatically, but this doesn't work for static linking. Add the needed libraries explicitely to the feature probe and the Makefile.

---
 tools/build/feature/Makefile | 2 +-
 tools/perf/config/Makefile   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/build/feature/Makefile +1 -1
index 463ed8f..179fc1a 100644
@@ -70,7 +70,7 @@ test-glibc.bin:
 	$(BUILD)
 
 test-dwarf.bin:
-	$(BUILD) -ldw
+	$(BUILD) -ldw -lelf -lebl -lz -llzma -lbz2
 
 test-libelf-mmap.bin:
 	$(BUILD) -lelf
tools/perf/config/Makefile +1 -1
index 094ddae..384e0a6 100644
@@ -297,7 +297,7 @@ ifndef NO_LIBELF
     else
       CFLAGS += -DHAVE_DWARF_SUPPORT $(LIBDW_CFLAGS)
       LDFLAGS += $(LIBDW_LDFLAGS)
-      EXTLIBS += -ldw
+      EXTLIBS += -ldw -lelf -lebl -lz -lbz2 -llzma
       $(call detected,CONFIG_DWARF)
     endif # PERF_HAVE_DWARF_REGS
   endif # NO_DWARF
Signature · 1 line
2.4.3
maintainer Applied
#1 lore raw

Em Fri, Aug 07, 2015 at 03:18:48PM -0700, Andi Kleen escreveu:

Quoted 6 lines

From: Andi Kleen <[email protected]>

The Fedora 22 version of libdw requires a couple of extra libraries to link. With a dynamic link the dependencies are pulled in automatically, but this doesn't work for static linking. Add the needed libraries explicitely to the feature probe and the Makefile.

Thanks, applied.

- Arnaldo

#2 lore raw
In reply to Andi Kleen
Quoted 42 lines · Andi Kleen

From: Andi Kleen <[email protected]>

The Fedora 22 version of libdw requires a couple of extra libraries to link. With a dynamic link the dependencies are pulled in automatically, but this doesn't work for static linking. Add the needed libraries explicitely to the feature probe and the Makefile.

---
 tools/build/feature/Makefile | 2 +-
 tools/perf/config/Makefile   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
tools/build/feature/Makefile +1 -1
index 463ed8f..179fc1a 100644
@@ -70,7 +70,7 @@ test-glibc.bin:
 	$(BUILD)
 
 test-dwarf.bin:
-	$(BUILD) -ldw
+	$(BUILD) -ldw -lelf -lebl -lz -llzma -lbz2
 
 test-libelf-mmap.bin:
 	$(BUILD) -lelf
tools/perf/config/Makefile +1 -1
index 094ddae..384e0a6 100644
@@ -297,7 +297,7 @@ ifndef NO_LIBELF
     else
       CFLAGS += -DHAVE_DWARF_SUPPORT $(LIBDW_CFLAGS)
       LDFLAGS += $(LIBDW_LDFLAGS)
-      EXTLIBS += -ldw
+      EXTLIBS += -ldw -lelf -lebl -lz -lbz2 -llzma
       $(call detected,CONFIG_DWARF)
     endif # PERF_HAVE_DWARF_REGS
   endif # NO_DWARF
Signature · 1 line
2.4.3

please also update the warning, as now it's not obvious you need to install also bz2 libs (bzip2-devel on Fedora) for dwarf support.. we already have check for lzma

thanks,
jirka

[jolsa@krava perf]$ make
BUILD: Doing 'make -j4' parallel build

Auto-detecting system features:
... dwarf: [ OFF ]

...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]

config/Makefile:267: No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev

author
#3 lore raw
Quoted 3 lines

please also update the warning, as now it's not obvious you need to install also bz2 libs (bzip2-devel on Fedora) for dwarf support.. we already have check for lzma

The package should already pull it in as a dependency.

-Andi

#4 lore raw

Em Sat, Aug 08, 2015 at 06:42:19PM +0200, Andi Kleen escreveu:

Quoted 5 lines
Quoted 3 lines

please also update the warning, as now it's not obvious you need to install also bz2 libs (bzip2-devel on Fedora) for dwarf support.. we already have check for lzma

The package should already pull it in as a dependency.

Noticed that this regresses my environment, Fedora 21:

[acme@zoo linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; m
make: Entering directory '/home/git/linux/tools/perf'
BUILD: Doing 'make -j4' parallel build

Auto-detecting system features:
... dwarf: [ OFF ]

  ...                         glibc: [ on  ]
  ...                          gtk2: [ on  ]
  ...                      libaudit: [ on  ]
  ...                        libbfd: [ on  ]
  ...                        libelf: [ on  ]
  ...                       libnuma: [ on  ]
  ...                       libperl: [ on  ]
  ...                     libpython: [ on  ]
  ...                      libslang: [ on  ]
  ...                     libunwind: [ on  ]
  ...            libdw-dwarf-unwind: [ on  ]
  ...                          zlib: [ on  ]
  ...                          lzma: [ on  ]

config/Makefile:267: No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev
MKDIR /tmp/build/perf/util/

Have not investigated, just noticed that dwarf is disabled if this patch is applied, removing it for now, will check later.

- Arnaldo