Patch "mmc: omap_hsmmc: Fix DTO and DCRC handling" has been added to the 4.1-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mmc: omap_hsmmc: Fix DTO and DCRC handling
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mmc-omap_hsmmc-fix-dto-and-dcrc-handling.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
408806f740497c5d71f9c305b3d6aad260ff186dMon Sep 17 00:00:00 2001
From: Kishon Vijay Abraham I <[email protected]>
Date: Tue, 16 Jun 2015 16:07:17 +0530
Subject: mmc: omap_hsmmc: Fix DTO and DCRC handling
From: Kishon Vijay Abraham I <[email protected]>
commit 408806f740497c5d71f9c305b3d6aad260ff186d upstream.
DTO/DCRC errors were not being informed to the mmc core since commit ae4bf788ee9b ("mmc: omap_hsmmc: consolidate error report handling of HSMMC IRQ"). This commit made sure 'end_trans' is never set on DTO/DCRC errors. This is because after this commit 'host->data' is checked after it has been cleared to NULL by omap_hsmmc_dma_cleanup().
Because 'end_trans' is never set, omap_hsmmc_xfer_done() is never invoked making core layer not to be aware of DTO/DCRC errors. Because of this any command invoked after DTO/DCRC error leads to a hang.
Fix this by checking for 'host->data' before it is actually cleared.
HSMMC IRQ")
--- drivers/mmc/host/omap_hsmmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/mmc/host/omap_hsmmc.c +4 -4
@@ -1062,6 +1062,10 @@ static void omap_hsmmc_do_irq(struct omaif (status & (CTO_EN |CCRC_EN )) end_cmd =1 ; +if (host->data || host->response_busy) { + end_trans = !end_cmd; + host->response_busy =0 ; + }if (status & (CTO_EN |DTO_EN ))hsmmc_command_incomplete (host, -ETIMEDOUT , end_cmd);else if (status & (CCRC_EN |DCRC_EN ))
@@ -1081,10 +1085,6 @@ static void omap_hsmmc_do_irq(struct oma }dev_dbg (mmc_dev (host->mmc),"AC12 err: 0x%x\n" , ac12); } -if (host->data || host->response_busy) { - end_trans = !end_cmd; - host->response_busy =0 ; - } }OMAP_HSMMC_WRITE (host->base,STAT , status);
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/mmc-omap_hsmmc-fix-dto-and-dcrc-handling.patch