Skip to contentSkip to conversation

Patch "Input: zforce - don't overwrite the stack" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: zforce - don't overwrite the stack

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-zforce-don-t-overwrite-the-stack.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7d01cd261c76f95913c81554a751968a1d282d3a Mon Sep 17 00:00:00 2001

From: Oleksij Rempel <[email protected]>
Date: Mon, 13 Jul 2015 09:54:42 -0700
Subject: Input: zforce - don't overwrite the stack

From: Oleksij Rempel <[email protected]>

commit 7d01cd261c76f95913c81554a751968a1d282d3a upstream.

If we get a corrupted packet with PAYLOAD_LENGTH > FRAME_MAXSIZE, we will silently overwrite the stack.

---
 drivers/input/touchscreen/zforce_ts.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/zforce_ts.c +1 -1
@@ -430,7 +430,7 @@ static int zforce_read_packet(struct zfo
 		goto unlock;
 	}
 
-	if (buf[PAYLOAD_LENGTH] == 0) {
+	if (buf[PAYLOAD_LENGTH] == 0 || buf[PAYLOAD_LENGTH] > FRAME_MAXSIZE) {
 		dev_err(&client->dev, "invalid payload length: %d\n",
 			buf[PAYLOAD_LENGTH]);
 		ret = -EIO;

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/input-zforce-don-t-overwrite-the-stack.patch