Patch "n_tty: signal and flush atomically" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
n_tty: signal and flush atomically
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
n_tty-signal-and-flush-atomically.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
3b19e032295647b7be2aa3be62510db4aaeda759Mon Sep 17 00:00:00 2001
From: Peter Hurley <[email protected]>
Date: Sat, 27 Jun 2015 09:21:32 -0400
Subject: n_tty: signal and flush atomically
From: Peter Hurley <[email protected]>
commit 3b19e032295647b7be2aa3be62510db4aaeda759 upstream.
When handling signalling char, claim the termios write lock before signalling waiting readers and writers to prevent further i/o before flushing the echo and output buffers. This prevents a userspace signal handler which may output from racing the terminal flush.
Reference: Bugzilla #99351 ("Output truncated in ssh session after...")
--- drivers/tty/n_tty.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
drivers/tty/n_tty.c +13 -3
@@ -1108,19 +1108,29 @@ static void eraser(unsigned char c, stru* Locking: ctrl_lock */ -static void isig (int sig,struct tty_struct *tty) +static void __isig (int sig,struct tty_struct *tty) { -struct n_tty_data *ldata = tty->disc_data;struct pid *tty_pgrp =tty_get_pgrp (tty);if (tty_pgrp) {kill_pgrp (tty_pgrp, sig,1 );put_pid (tty_pgrp); } +} + +static void isig (int sig,struct tty_struct *tty) +{ +struct n_tty_data *ldata = tty->disc_data; -if (!L_NOFLSH (tty)) { +if (L_NOFLSH (tty)) { +/* signal only */ +__isig (sig, tty); + + }else {/* signal and flush */ up_read (&tty->termios_rwsem);down_write (&tty->termios_rwsem); +__isig (sig, tty); +/* clear echo buffer */ mutex_lock (&ldata->output_lock); ldata->echo_head = ldata->echo_tail =0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/serial-core-fix-crashes-while-echoing-when-closing.patch queue-4.1/n_tty-signal-and-flush-atomically.patch