Skip to contentSkip to conversation

Patch "MIPS: unaligned: Fix build error on big endian R6 kernels" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 10, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

MIPS: unaligned: Fix build error on big endian R6 kernels

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mips-unaligned-fix-build-error-on-big-endian-r6-kernels.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 531a6d599f4304156236ebdd531aaa80be61868d Mon Sep 17 00:00:00 2001

From: James Cowgill <[email protected]>
Date: Tue, 23 Jun 2015 12:02:00 +0100
Subject: MIPS: unaligned: Fix build error on big endian R6 kernels

From: James Cowgill <[email protected]>

commit 531a6d599f4304156236ebdd531aaa80be61868d upstream.

Commit eeb538950367 ("MIPS: unaligned: Prevent EVA instructions on kernel unaligned accesses") renamed the Load* and Store* defines in unaligned.c to _Load* and _Store* as part of its fix. One define was missed out which causes big endian R6 kernels to fail to build.

arch/mips/kernel/unaligned.c:880:35:
error: implicit declaration of function '_StoreDW'

 #define StoreDW(addr, value, res) _StoreDW(addr, value, res)
                                   ^
Fixes eeb538950367 ("MIPS: unaligned: Prevent EVA instructions on kernel unaligned accesses")
Cc Markos Chandras <[email protected]>

Patchwork: https://patchwork.linux-mips.org/patch/10575/

---
 arch/mips/kernel/unaligned.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/kernel/unaligned.c +1 -1
@@ -438,7 +438,7 @@ do {
 		: "memory");                                \
 } while(0)
 
-#define     StoreDW(addr, value, res) \
+#define     _StoreDW(addr, value, res) \
 do {                                                        \
 		__asm__ __volatile__ (                      \
 			".set\tpush\n\t"		    \

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/mips-replace-add-and-sub-instructions-in-relocate_kernel.s-with-addiu.patch queue-4.1/mips-unaligned-fix-build-error-on-big-endian-r6-kernels.patch