Skip to contentSkip to conversation

Patch "dmaengine: pl330: Fix overflow when reporting residue in memcpy" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 10, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

dmaengine: pl330: Fix overflow when reporting residue in memcpy

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
dmaengine-pl330-fix-overflow-when-reporting-residue-in-memcpy.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ae128293d97404f491dc76f1843c7adacfec3441 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Mon, 15 Jun 2015 17:25:16 +0900
Subject: dmaengine: pl330: Fix overflow when reporting residue in memcpy

From: Krzysztof Kozlowski <[email protected]>

commit ae128293d97404f491dc76f1843c7adacfec3441 upstream.

During memcpy operations the residue was always set to an u32 overflowed value.

In pl330_tx_status() function number of currently transferred bytes was subtracted from internal "bytes_requested" field. However this "bytes_requested" was not initialized at start to length of memcpy buffer so transferred bytes were subtracted from 0 causing overflow.

Fixes aee4d1fac887 ("dmaengine: pl330: improve pl330_tx_status() function")
---
 drivers/dma/pl330.c |    1 +
 1 file changed, 1 insertion(+)
drivers/dma/pl330.c +1 -0
@@ -2621,6 +2621,7 @@ pl330_prep_dma_memcpy(struct dma_chan *c
 		desc->rqcfg.brst_len = 1;
 
 	desc->rqcfg.brst_len = get_burst_len(desc, len);
+	desc->bytes_requested = len;
 
 	desc->txd.flags = flags;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/dmaengine-pl330-fix-overflow-when-reporting-residue-in-memcpy.patch