Skip to contentSkip to conversation

Patch "usb: udc: core: add device_del() call to error pathway" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 10, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: udc: core: add device_del() call to error pathway

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-udc-core-add-device_del-call-to-error-pathway.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c93e64e91248becd0edb8f01723dff9da890e2ab Mon Sep 17 00:00:00 2001

From: Alan Stern <[email protected]>
Date: Fri, 16 Jan 2015 11:32:51 -0500
Subject: usb: udc: core: add device_del() call to error pathway

From: Alan Stern <[email protected]>

commit c93e64e91248becd0edb8f01723dff9da890e2ab upstream.

This patch fixes a bug in the error pathway of usb_add_gadget_udc_release() in udc-core.c. If the udc registration fails, the gadget registration is not fully undone; there's a put_device(&gadget->dev) call but no device_del().

---
 drivers/usb/gadget/udc/udc-core.c |    1 +
 1 file changed, 1 insertion(+)
drivers/usb/gadget/udc/udc-core.c +1 -0
@@ -321,6 +321,7 @@ err4:
 
 err3:
 	put_device(&udc->dev);
+	device_del(&gadget->dev);
 
 err2:
 	put_device(&gadget->dev);

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/usb-chipidea-ehci_init_driver-is-intended-to-call-one-time.patch queue-4.1/usb-udc-core-add-device_del-call-to-error-pathway.patch