Patch "dm: fix dm_merge_bvec regression on 32 bit systems" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
dm: fix dm_merge_bvec regression on 32 bit systems
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
dm-fix-dm_merge_bvec-regression-on-32-bit-systems.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
bd4aaf8f9b85d6b2df3231fd62b219ebb75d3568Mon Sep 17 00:00:00 2001
From: Mike Snitzer <[email protected]>
Date: Mon, 3 Aug 2015 09:54:58 -0400
Subject: dm: fix dm_merge_bvec regression on 32 bit systems
From: Mike Snitzer <[email protected]>
commit bd4aaf8f9b85d6b2df3231fd62b219ebb75d3568 upstream.
A DM regression on 32 bit systems was reported against v4.2-rc3 here:
https://lkml.org/lkml/2015/7/29/401
Fix this by reverting both commit 1c220c69 ("dm: fix casting bug in dm_merge_bvec()") and 148e51ba ("dm: improve documentation and code clarity in dm_merge_bvec"). This combined revert is done to eliminate the possibility of a partial revert in stable@ kernels.
In hindsight the correct fix, at the time 1c220c69 was applied to fix the regression that 148e51ba introduced, should've been to simply revert 148e51ba.
--- drivers/md/dm.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-)
drivers/md/dm.c +10 -17
@@ -1719,7 +1719,8 @@ static int dm_merge_bvec(struct request_struct mapped_device *md = q->queuedata;struct dm_table *map =dm_get_live_table_fast (md);struct dm_target *ti; -sector_t max_sectors, max_size =0 ; +sector_t max_sectors; +int max_size =0 ;if (unlikely (!map)) goto out;
@@ -1732,18 +1733,10 @@ static int dm_merge_bvec(struct request_* Find maximum amount of I/O that won't need splitting */ max_sectors =min (max_io_len (bvm->bi_sector, ti), - (sector_t )queue_max_sectors (q)); + (sector_t )BIO_MAX_SECTORS ); max_size = (max_sectors <<SECTOR_SHIFT ) - bvm->bi_size; - -/* -* FIXME: this stop-gap fix _must_ be cleaned up (by passing a sector_t -* to the targets' merge function since it holds sectors not bytes). -* Just doing this as an interim fix for stable@ because the more -* comprehensive cleanup of switching to sector_t will impact every -* DM target that implements a ->merge hook. -*/ -if (max_size >INT_MAX ) - max_size =INT_MAX ; +if (max_size <0 ) + max_size =0 ;/* * merge_bvec_fn() returns number of bytes
@@ -1751,13 +1744,13 @@ static int dm_merge_bvec(struct request_* max is precomputed maximal io size */ if (max_size && ti->type->merge) - max_size = ti->type->merge (ti, bvm, biovec, (int ) max_size); + max_size = ti->type->merge (ti, bvm, biovec, max_size);/* * If the target doesn't support merge method and some of the devices -* provided their merge_bvec method (we know this by looking for the -* max_hw_sectors that dm_set_device_limits may set), then we can't -* allow bios with multiple vector entries. So always set max_size -* to 0, and the code below allows just one page. +* provided their merge_bvec method (we know this by looking at +* queue_max_hw_sectors), then we can't allow bios with multiple vector +* entries. So always set max_size to 0, and the code below allows +* just one page. */ else if (queue_max_hw_sectors (q) <=PAGE_SIZE >>9 ) max_size =0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/dm-fix-dm_merge_bvec-regression-on-32-bit-systems.patch