coccinelle: add style check for assignment in if
RFC v2 1/1 coccinelle: add style check for assignment in if
Add a semantic patch for fixing some cases of checkpatch.pl error:
ERROR: do not use assignment in if condition
Signed-off-by Kris Borer <[email protected]>
--- scripts/coccinelle/style/assignment_in_if.cocci | 92 +++++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 scripts/coccinelle/style/assignment_in_if.cocci
scripts/coccinelle/style/assignment_in_if.cocci new file +92 -0
@@ -0,0 +1,92 @@ +// find checkpatch.pl errors of the type: +// ERROR: do not use assignment in if condition +// +// This script is designed to correct code where assignments exist in if +// conditions. It is only capable of handling a subset of such problems. +// +// For example: +// +// if(result = myfun()) +// +// would become: +// +// result = myfun(); +// if(result) +// +// Confidence: Moderate + + +// if ( ret = call() ) + at if1@ +identifier i; +expression E; +statement S1, S2; +@@ + ++ i = E; + if ( +- (i = E) ++ i + ) S1 else S2 + + +// if ( (ret = call()) < 0 ) +@if2@ +identifier i; +expression E; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +- (i = E) ++ i + b ... ) S1 else S2 + +// if ( ptr->fun && (ret = ptr->fun()) < 0 ) +@if3@ +identifier i, i2; +expression E1, E2; +constant c; +binary operator b; +@@ + ++ if( E1->i ) { ++ i2 = E2; ++ if (i2 b c) { +- if( E1->i && ((i2 = E2) b c) ) { + ... +- } ++ } ++ } + +// if ( (ret = call()) < 0 && ret != -1 ) + at if4@ +identifier i; +expression E, E2; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +- (i = E) ++ i + b + ... && E2 ) S1 else S2 + +// if ( (ret = call()) < 0 && ret != -1 && ret != -2 ) +@if5@ +identifier i; +expression E, E2, E3; +statement S1, S2; +binary operator b; +@@ + ++ i = E; + if ( +- (i = E) ++ i + b + ... && E2 && E3 ) S1 else S2
Signature · 1 line
1.9.1