Patch "HID: hid-input: Fix accessing freed memory during device disconnect" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
HID: hid-input: Fix accessing freed memory during device disconnect
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hid-hid-input-fix-accessing-freed-memory-during-device-disconnect.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
0621809e37936e7c2b3eac9165cf2aad7f9189ebMon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Mon, 3 Aug 2015 14:57:30 +0900
Subject: HID: hid-input: Fix accessing freed memory during device disconnect
From: Krzysztof Kozlowski <[email protected]>
commit 0621809e37936e7c2b3eac9165cf2aad7f9189eb upstream.
During unbinding the driver was dereferencing a pointer to memory already freed by power_supply_unregister().
Driver was freeing its internal description of battery through pointers stored in power_supply structure. However, because the core owns the power supply instance, after calling power_supply_unregister() this memory is freed and the driver cannot access these members.
Fix this by storing the pointer to internal description of battery in a local variable before calling power_supply_unregister(), so the pointer remains valid.
--- drivers/hid/hid-input.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/hid/hid-input.c +5 -2
@@ -462,12 +462,15 @@ out:static void hidinput_cleanup_battery (struct hid_device *dev) { +const struct power_supply_desc *psy_desc; +if (!dev->battery)return ; + psy_desc = dev->battery->desc;power_supply_unregister (dev->battery); -kfree (dev->battery->desc->name); -kfree (dev->battery->desc); +kfree (psy_desc->name); +kfree (psy_desc); dev->battery =NULL ; }#else /* !CONFIG_HID_BATTERY_STRENGTH */
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/hid-hid-input-fix-accessing-freed-memory-during-device-disconnect.patch