Skip to contentSkip to conversation

rpc.gssd: Replace exit(0) by return in process_krb5_upcall

PATCH In review [email protected] 2 participants 3 messages Aug 19, 2015 – Sep 8, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpc.gssd: Replace exit(0) by return in process_krb5_upcall

From: Andy Adamson <[email protected]>

exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for each upcall, ignoring a valid TGT in the kerberos credential cache.

---
 utils/gssd/gssd_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/gssd/gssd_proc.c +1 -1
index 03afc8b..3fc7bba 100644
@@ -684,7 +684,7 @@ out:
 		AUTH_DESTROY(auth);
 	if (rpc_clnt)
 		clnt_destroy(rpc_clnt);
-	exit(0);
+	return;
 
 out_return_error:
 	do_error_downcall(fd, uid, downcall_err);
Signature · 1 line
1.9.3 (Apple Git-50)
#1 lore raw
Quoted 7 lines · On 08/19/2015 03:58 PM, [email protected] wrote:

From: Andy Adamson <[email protected]>

exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for each upcall, ignoring a valid TGT in the kerberos credential cache.

Committed...

steved.

Quoted 18 lines
---
 utils/gssd/gssd_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/gssd/gssd_proc.c +1 -1
index 03afc8b..3fc7bba 100644
@@ -684,7 +684,7 @@ out:
 		AUTH_DESTROY(auth);
 	if (rpc_clnt)
 		clnt_destroy(rpc_clnt);
-	exit(0);
+	return;
 
 out_return_error:
 	do_error_downcall(fd, uid, downcall_err);
#2 lore raw
Quoted 11 lines · Steve Dickson
Quoted 7 lines · On 08/19/2015 03:58 PM, [email protected] wrote:

From: Andy Adamson <[email protected]>

exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for each upcall, ignoring a valid TGT in the kerberos credential cache.

Committed...

This has been reverted due to child processes not exiting on upcalls.

steved.

Quoted 26 lines

steved.

Quoted 10 lines
---
 utils/gssd/gssd_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/gssd/gssd_proc.c +0 -0
index 03afc8b..3fc7bba 100644

utils/gssd/gssd_proc.c out: · line 690

Quoted 8 lines
utils/gssd/gssd_proc.c +1 -1
@@ -684,7 +684,7 @@ out:
 		AUTH_DESTROY(auth);
 	if (rpc_clnt)
 		clnt_destroy(rpc_clnt);
-	exit(0);
+	return;
 
 out_return_error:
 	do_error_downcall(fd, uid, downcall_err);

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html