Skip to contentSkip to conversation

uclibc: Add SRCBRANCH for use by SRC_URI

PATCH In review Yen-Chin Lee 3 participants 5 messages Aug 20, 2015 – Aug 21, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uclibc: Add SRCBRANCH for use by SRC_URI

Add SRCBRANCH to control git branch.

---
 meta/recipes-core/uclibc/uclibc-git.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/recipes-core/uclibc/uclibc-git.inc +3 -1
index 14a577f..e179fc7 100644
@@ -4,7 +4,9 @@ PV = "0.9.33+git${SRCPV}"
 
 FILESEXTRAPATHS =. "${FILE_DIRNAME}/uclibc-git:"
 
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \
         file://uClibc.machine \
         file://uClibc.distro \
         file://obstack.cfg \
Signature · 1 line
2.3.6
#1 lore raw

meta/recipes-core/uclibc/uclibc-git.inc PV = "0.9.33+git${SRCPV}" · line 9

Quoted 4 lines · Yen-Chin Lee
meta/recipes-core/uclibc/uclibc-git.inc +3 -1
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \

this is ok. Just call is BRANCH instead of SRCBRANCH

#2 lore raw
Quoted 7 lines · Khem Raj

meta/recipes-core/uclibc/uclibc-git.inc PV = "0.9.33+git${SRCPV}" · line 9

Quoted 4 lines · Yen-Chin Lee
meta/recipes-core/uclibc/uclibc-git.inc +3 -1
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \

this is ok. Just call is BRANCH instead of SRCBRANCH

Personally I prefer SRCBRANCH. This is personal option though.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw
Quoted 10 lines · Otavio Salvador
Quoted 7 lines · Khem Raj

meta/recipes-core/uclibc/uclibc-git.inc PV = "0.9.33+git${SRCPV}" · line 9

Quoted 4 lines · Yen-Chin Lee
meta/recipes-core/uclibc/uclibc-git.inc +3 -1
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \

this is ok. Just call is BRANCH instead of SRCBRANCH

Personally I prefer SRCBRANCH. This is personal option though.

consistency is what I wanted here. There is BRANCH used for same reason in some other recipes, it can be any name I don't have a preference.
if you prefer SRCBRANCH, propose another patch to rename other usecases in metadata to use it as well.

Quoted 5 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750

#4 lore raw
Quoted 11 lines · Khem Raj
Quoted 9 lines · Otavio Salvador
Quoted 7 lines · Khem Raj

meta/recipes-core/uclibc/uclibc-git.inc PV = "0.9.33+git${SRCPV}" · line 9

Quoted 4 lines · Yen-Chin Lee
meta/recipes-core/uclibc/uclibc-git.inc +3 -1
-SRC_URI = "git://uclibc.org/uClibc.git;branch=master \
+SRCBRANCH ??= "master"
+
+SRC_URI = "git://uclibc.org/uClibc.git;branch=${SRCBRANCH} \

this is ok. Just call is BRANCH instead of SRCBRANCH

Quoted 7 lines
Quoted 1 line

Personally I prefer SRCBRANCH. This is personal option though.

consistency is what I wanted here. There is BRANCH used for same reason in some other recipes, it can be any name I don't have a preference.
if you prefer SRCBRANCH, propose another patch to rename other usecases in metadata to use it as well.

Yes; I sent this for OE-Core but ended using SRC_BRANCH so it clearly relates to SRC_URI.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750