Skip to contentSkip to conversation

usb: message: remove redundant declaration

PATCH Superseded Kris Borer 2 participants 2 messages Aug 25, 2015 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Kris Borer

author
#0 lore raw

PATCH 1/1 usb: message: remove redundant declaration

Fix the Sparse warning:

message.c:1390:21: warning: symbol 'i' shadows an earlier one message.c:1294:13: originally declared here

---
 drivers/usb/core/message.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/core/message.c +0 -1
index f368d20..e83648d 100644
@@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
 	 * new altsetting.
 	 */
 	if (manual) {
-		int i;
 
 		for (i = 0; i < alt->desc.bNumEndpoints; i++) {
 			epaddr = alt->endpoint[i].desc.bEndpointAddress;
Signature · 1 line
1.9.1
#1 lore raw

Hello.

Quoted 15 lines · Kris Borer

Fix the Sparse warning:

message.c:1390:21: warning: symbol 'i' shadows an earlier one message.c:1294:13: originally declared here

---
  drivers/usb/core/message.c | 1 -
  1 file changed, 1 deletion(-)
drivers/usb/core/message.c +0 -0
index f368d20..e83648d 100644

drivers/usb/core/message.c int usb_set_interface(struct usb_device *dev, int interface, int alternate) · line 1390

Quoted 5 lines
drivers/usb/core/message.c +0 -1
@@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
  	 * new altsetting.
  	 */
  	if (manual) {
-		int i;
 

Why not remove (now unneeded) empty line?

drivers/usb/core/message.c int usb_set_interface(struct usb_device *dev, int interface, int alternate) · line 1392

Quoted 2 lines
drivers/usb/core/message.c +0 -0
  		for (i = 0; i < alt->desc.bNumEndpoints; i++) {
  			epaddr = alt->endpoint[i].desc.bEndpointAddress;

MBR, Sergei