Skip to contentSkip to conversation

sanity.bbclass: remove forced abspath for SSTATE_MIRRORS

PATCH Superseded Christopher Larson 1 participant 3 messages Aug 26, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sanity.bbclass: remove forced abspath for SSTATE_MIRRORS

From: Christopher Larson <[email protected]>

The sstate URI is relative to begin with, so it's completely valid to want to alter it in a way that keeps it relative using a mirror, and I have real world cases where this is causing issues. Remove the check which errors out on relative file:// paths.

---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)
meta/classes/sanity.bbclass +0 -2
index ef90fc8..c142274 100644
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
Signature · 1 line
2.2.1
#1 lore raw

PATCH v2 1/1 sanity.bbclass: remove forced abspath for SSTATE_MIRRORS

From: Christopher Larson <[email protected]>

The sstate URI is relative to begin with, so it's completely valid to want to alter it in a way that keeps it relative using a mirror, and I have real world cases where this is causing issues. Remove the check which warns on relative file:// paths.

---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)
meta/classes/sanity.bbclass +0 -2
index ef90fc8..c142274 100644
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
Signature · 1 line
2.2.1
#2 lore raw

PATCH v3 1/1 sanity.bbclass: remove abspath warning for SSTATE_MIRRORS

From: Christopher Larson <[email protected]>

The sstate URI is relative to begin with, so it's completely valid to want to alter it in a way that keeps it relative using a mirror, and I have real world cases where this is causing issues. Remove the warning.

---
 meta/classes/sanity.bbclass | 2 --
 1 file changed, 2 deletions(-)
meta/classes/sanity.bbclass +0 -2
index ef90fc8..c142274 100644
@@ -818,8 +818,6 @@ def check_sanity_everybuild(status, d):
                 continue
 
             if mirror.startswith('file://'):
-                if not mirror.startswith('file:///'):
-                    bb.warn('Invalid file url in %s: %s, must be absolute path (file:///)' % (mirror_var, mirror_entry))
                 import urlparse
                 check_symlink(urlparse.urlparse(mirror).path, d)
                 # SSTATE_MIRROR ends with a /PATH string
Signature · 1 line
2.2.1