Skip to contentSkip to conversation

Add some missing symlinks and hardlinks requirements.

PATCH In review Ari Sundholm 2 participants 3 messages Aug 26, 2015 – Aug 27, 2015

lore
Share & tools
lore

Ari Sundholm

author
#0 lore raw

PATCH 2/2 Add some missing symlinks and hardlinks requirements.

From: Ari Sundholm <[email protected]>

Signed-off-by Ari Sundholm <[email protected]>
---
 tests/generic/067 |    1 +
 tests/generic/236 |    1 +
 tests/generic/294 |    1 +
 3 files changed, 3 insertions(+)
tests/generic/067 +1 -0
index 7a4840b..8322ef8 100755
@@ -52,6 +52,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs generic
 _supported_os Linux
+_require_test_symlinks
 _require_test
 _require_scratch
 _require_loop
tests/generic/236 +1 -0
index 12ea0bc..df0250f 100755
@@ -43,6 +43,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fs generic
 # only Linux supports fallocate
 _supported_os Linux
+_require_test_hardlinks
 _require_test
 
 rm -f $TEST_DIR/ouch*
tests/generic/294 +1 -0
index 3fa6ba2..944b6a1 100755
@@ -46,6 +46,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs generic
 _supported_os Linux
+_require_test_hardlinks
 _require_scratch
 
 rm -f $seqres.full
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 26 lines · Ari Sundholm

From: Ari Sundholm <[email protected]>

Signed-off-by Ari Sundholm <[email protected]>
---
 tests/generic/067 |    1 +
 tests/generic/236 |    1 +
 tests/generic/294 |    1 +
 3 files changed, 3 insertions(+)
tests/generic/067 +1 -0
index 7a4840b..8322ef8 100755
@@ -52,6 +52,7 @@ _cleanup()
 # Modify as appropriate.
 _supported_fs generic
 _supported_os Linux
+_require_test_symlinks
 _require_test
 _require_scratch
 _require_loop
tests/generic/236 +0 -0
index 12ea0bc..df0250f 100755

tests/generic/236 trap "_cleanup; exit \$status" 0 1 2 3 15 · line 47

Quoted 5 lines
tests/generic/236 +1 -0
@@ -43,6 +43,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fs generic
 # only Linux supports fallocate
 _supported_os Linux
+_require_test_hardlinks
 _require_test

This belongs in the previous patch that introduced the check.

Cheers,

DAve.

Signature · 2 lines
Dave Chinner
[email protected]
author
#2 lore raw

Hello Dave!

Quoted 1 line · Dave Chinner

This belongs in the previous patch that introduced the check.

OK, I will combine the hard link part of the patches, but I think in this case the symlink part should have its own patch as it is sort of unrelated (even though it's a very small change by itself).

Best regards,
Ari Sundholm
[email protected]