net, skbuff: Get rid of unused skb_propagate_pfmemalloc
PATCH 1/1 net, skbuff: Get rid of unused skb_propagate_pfmemalloc
From: Michal Hocko <[email protected]>
It seems that skb_propagate_pfmemalloc has never had a user since it was introduced by 0614002bb5f7 ("netvm: propagate page->pfmemalloc from skb_alloc_page to skb"). Remove it.
---
Hi,
this has been noticed while working on 2f064f3485cd ("mm: make page pfmemalloc check more robust").
include/linux/skbuff.h | 12 ------------ 1 file changed, 12 deletions(-)
include/linux/skbuff.h +0 -12
@@ -2252,18 +2252,6 @@ static inline struct page *dev_alloc_page(void) }/** -* skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page -* @page: The page that was allocated from skb_alloc_page -* @skb: The skb that may need pfmemalloc set -*/ -static inline void skb_propagate_pfmemalloc (struct page *page, -struct sk_buff *skb) -{ -if (page_is_pfmemalloc (page)) - skb->pfmemalloc = true; -} - -/** * skb_frag_page - retrieve the page referred to by a paged fragment * @frag: the paged fragment *
Signature · 1 line
2.5.0
Quoted 11 lines · On Thu 27-08-15 10:46:37, [email protected] wrote:
From: Michal Hocko <[email protected]>
It seems that
skb_propagate_pfmemallochas never had a user since it was introduced by0614002bb5f7("netvm: propagatepage->pfmemallocfromskb_alloc_pageto skb"). Remove it.Signed-off-by Michal Hocko <[email protected]>---
Hi,
this has been noticed while working on2f064f3485cd("mm: make page pfmemalloc check more robust").
Has this just fallen through cracks or it is not interesting?
Quoted 30 lines
include/linux/skbuff.h | 12 ------------ 1 file changed, 12 deletions(-)include/linux/skbuff.h +0
-12@@ -2252,18 +2252,6 @@ static inline struct page *dev_alloc_page(void) }/** -* skb_propagate_pfmemalloc - Propagate pfmemalloc if skb is allocated after RX page -* @page: The page that was allocated from skb_alloc_page -* @skb: The skb that may need pfmemalloc set -*/ -static inline void skb_propagate_pfmemalloc (struct page *page, -struct sk_buff *skb) -{ -if (page_is_pfmemalloc (page)) - skb->pfmemalloc = true; -} - -/** * skb_frag_page - retrieve the page referred to by a paged fragment * @frag: the paged fragment * Signature · 1 line
2.5.0
Signature · 2 lines
Michal Hocko SUSE Labs