ARM926: Display Ethernet info in do_bdinfo only if CONFIG_CMD_NET is defined

Hi,

This Patch adds if define to bdinfo command to display ethernet information only if CONFIG_CMD_NET is defined for arm modules.

@@ -314,6 +314,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int fl
 		print_num("-> size",	bd->bi_dram[i].size);
 	}
 
+#if defined(CONFIG_CMD_NET)
 	puts ("ethaddr     =");
 	for (i=0; i<6; ++i) {
 		printf ("%c%02X", i ? ':' : ' ', bd->bi_enetaddr[i]);

@@ -321,6 +322,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int fl
 	puts  ( "\n"
 		"ip_addr     = ");
 	print_IPaddr (bd->bi_ip_addr);
+#endif		
 	printf ("\n"
 		"baudrate    = %d bps\n", bd->bi_baudrate);
 

I welcome comments, complaints, suggestions and advices.

Regards
Gururaja

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-Display-Ethernet-info-in-do_bdinfo-only-if-CONFIG_CMD_NET-is-defined-tp14408226p14408226.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

Hi,

This Patch adds if define to bdinfo command to display ethernet information only if CONFIG_CMD_NET is defined for arm modules.

@@ -314,6 +314,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int fl
 		print_num("-> size",	bd->bi_dram[i].size);
 	}
 
+#if defined(CONFIG_CMD_NET)
 	puts ("ethaddr     =");
 	for (i=0; i<6; ++i) {
 		printf ("%c%02X", i ? ':' : ' ', bd->bi_enetaddr[i]);

@@ -321,6 +322,7 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int fl
 	puts  ( "\n"
 		"ip_addr     = ");
 	print_IPaddr (bd->bi_ip_addr);
+#endif		
 	printf ("\n"
 		"baudrate    = %d bps\n", bd->bi_baudrate);
 

I welcome comments, complaints, suggestions and advices.

Regards
Gururaja

View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-Display-Ethernet-info-in-do_bdinfo-only-if-CONFIG_CMD_NET-is-defined-tp14408226p14408496.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

Um... you claim to do this for ARM modules only, but actually yoru code is a global modification to ALL systems.

And ARM doesn't even have a specific way to pass the MAC address to Linux.

Your modification makes no sense to me. I tend to reject it.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
                     several applications can crash at the same time.

Hi,

Sorry for the late reply. was out of connection from the e-world for some time.

At present, in the file u-boot-1.3.1/common/cmd_bdinfo.c,

(CONFIG_NIOS2) /* Nios-II */
at line 170
(CONFIG_MICROBLAZE) /* ! PPC, which leaves Microblaze */ at line 197
(CONFIG_M68K) /* M68K */
at line 239

for all these configs we have the ifdef's.

Only for CONFIG_PPC, (CONFIG_NIOS) /* NIOS*/ , MIPS & ARM doesnt have this ifdefs. hence i added this for ARM Config
Also this option i have added only to ARM section which is at the end. At this point in the code, all other configs (NIOS, PPC, MIPS etc) are eliminated and only ARM is left out.
So it doent effect any other systems.

Kindly correct me if i am wrong

Regards
Gururaja

-----Original Message-----
From: [email protected] [mailto:wd at denx.de]
Sent: Tuesday, January 08, 2008 11:51 PM
To: Gururaja Hebbar K R
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] [PATCH] ARM926: Display Ethernet info in do_bdinfo only if CONFIG_CMD_NET is defined

Um... you claim to do this for ARM modules only, but actually yoru code is a global modification to ALL systems.

And ARM doesn't even have a specific way to pass the MAC address to Linux.

Your modification makes no sense to me. I tend to reject it.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Microsoft Multitasking:
                     several applications can crash at the same time.

Wolfgang

Please expand on this comment for me.

Is there another architecture in U-Boot passing the MAC address that I could look at to understand what you mean?

Or are you referring to a kernel, architecture specific, command line feature?

Regards

Peter

He is referign to the numerous kcooments on this list over the past few years of how ARM dos not have a way for u-boot to pass inthe MAC to the kernel (via ATAG or any ohter easy way). THe kernel has to, by itself, figure out the MAC.

look at PPC.
old-style passses the MAC for each interface in the bd_t struct. new-style passes the mac address for each interface in the device tree (as local-mac-address tag)

This is highly useful where there is no _common_ place to store the MAC that the eth driver knows about without a platform specific hack. This way the driver just looks in the dts tree and is happy.

AVR32 passes it through ATAGs. That should be easily portable to ARM.

Look at setup_ethernet_tags() in lib_avr32/avr32_linux.c

Haavard

Easily portable from the technical point of view; but it will not be accepted for the ARM Linux kernel tree. See the FAQ.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4

There were no negative comments to this modification (just my own mis-interpretation), so I added this, thanks.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One of the advantages of being a captain is being able to ask for ad-
vice without necessarily having to take it.
	-- Kirk, "Dagger of the Mind", stardate 2715.2

Hi Wolfgang,

Thanks. Will sure learn about GIT Process.

Regards
Gururaja

-----Original Message-----
From: [email protected] [mailto:wd at denx.de]
Sent: Monday, February 04, 2008 2:19 PM
To: Gururaja Hebbar K R
Cc: u-boot-users at lists.sourceforge.net
Subject: Re: [U-Boot-Users] [PATCH] ARM926: Display Ethernet info in do_bdinfo only if CONFIG_CMD_NET is defined

There were no negative comments to this modification (just my own mis-interpretation), so I added this, thanks.

-0800

Umm... could you please start using git tools for creating patches etc.? That would make life much easier for us. Thanks.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
One of the advantages of being a captain is being able to ask for ad-
vice without necessarily having to take it.
	-- Kirk, "Dagger of the Mind", stardate 2715.2