devtool: make plugin_init optional

PATCH New Ed Bartosh 1 participant 1 message Aug 30, 2015

Share & tools

Ed Bartosh

author

2015-08-30 16:33 UTC #0 lore raw

PATCH 1/1 devtool: make plugin_init optional

So far all devtool and recipetool plugins were expected to have plugin_init function. This function is empty in most of plugins as they don't require initialisation.

Making plugin_init optional would allow not having empty plugin_init in every plugin.

Signed-off-by Ed Bartosh <[email protected]>

---
 scripts/lib/devtool/build-image.py               | 4 ----
 scripts/lib/devtool/deploy.py                    | 5 -----
 scripts/lib/devtool/standard.py                  | 5 -----
 scripts/lib/recipetool/append.py                 | 4 ----
 scripts/lib/recipetool/create_buildsys.py        | 3 ---
 scripts/lib/recipetool/create_buildsys_python.py | 4 ----
 scripts/lib/scriptutils.py                       | 2 +-
 7 files changed, 1 insertion(+), 26 deletions(-)

scripts/lib/devtool/build-image.py +0 -4

index 817703a..2c01428 100644
@@ -25,10 +25,6 @@ from devtool import exec_build_env_command, setup_tinfoil, parse_recipe
 
 logger = logging.getLogger('devtool')
 
-def plugin_init(pluginlist):
-    """Plugin initialization"""
-    pass
-
 def _get_recipes(workspace, config):
     """Get list of target recipes from the workspace."""
     result = []

scripts/lib/devtool/deploy.py +0 -5

index 448db96..fa93adf 100644
@@ -23,11 +23,6 @@ from devtool import exec_fakeroot, setup_tinfoil, DevtoolError
 
 logger = logging.getLogger('devtool')
 
-def plugin_init(pluginlist):
-    """Plugin initialization"""
-    pass
-
-
 def deploy(args, config, basepath, workspace):
     """Entry point for the devtool 'deploy' subcommand"""
     import re

scripts/lib/devtool/standard.py +0 -5

index de7afd9..2507ef9 100644
@@ -31,11 +31,6 @@ from devtool import parse_recipe
 logger = logging.getLogger('devtool')
 
 
-def plugin_init(pluginlist):
-    """Plugin initialization"""
-    pass
-
-
 def add(args, config, basepath, workspace):
     """Entry point for the devtool 'add' subcommand"""
     import bb

scripts/lib/recipetool/append.py +0 -4

index ed7d0d4..7fe4115 100644
@@ -33,10 +33,6 @@ logger = logging.getLogger('recipetool')
 
 tinfoil = None
 
-def plugin_init(pluginlist):
-    # Don't need to do anything here right now, but plugins must have this function defined
-    pass
-
 def tinfoil_init(instance):
     global tinfoil
     tinfoil = instance

scripts/lib/recipetool/create_buildsys.py +0 -3

index 6c9e0ef..ed14a53 100644
@@ -307,9 +307,6 @@ class MakefileRecipeHandler(RecipeHandler):
             self.genfunction(lines_after, 'do_install', ['# Specify install commands here'])
 
 
-def plugin_init(pluginlist):
-    pass
-
 def register_recipe_handlers(handlers):
     # These are in a specific order so that the right one is detected first
     handlers.append(CmakeRecipeHandler())

scripts/lib/recipetool/create_buildsys_python.py +0 -4

index f4f4212..e0af2a0 100644
@@ -711,10 +711,6 @@ def has_non_literals(value):
         return any(has_non_literals(v) for v in value)
 
 
-def plugin_init(pluginlist):
-    pass
-
-
 def register_recipe_handlers(handlers):
     # We need to make sure this is ahead of the makefile fallback handler
     handlers.insert(0, PythonRecipeHandler())

scripts/lib/scriptutils.py +1 -1

index fdf4b5d..0deecaa 100644
@@ -57,7 +57,7 @@ def load_plugins(logger, plugins, pluginpath):
             plugin = load_plugin(name)
             if hasattr(plugin, 'plugin_init'):
                 plugin.plugin_init(plugins)
-                plugins.append(plugin)
+            plugins.append(plugin)
 
 def git_convert_standalone_clone(repodir):
     """If specified directory is a git repository, ensure it's a standalone clone"""

Signature · 1 line

2.1.4