Skip to contentSkip to conversation

Staging: most: MOST and MOSTCORE should depend on HAS_DMA

PATCH In review Geert Uytterhoeven 2 participants 2 messages Sep 1, 2015 – Sep 7, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: most: MOST and MOSTCORE should depend on HAS_DMA

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!

As all MOST sub drivers use DMA functionality, add a dependency on HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.

---
 drivers/staging/most/Kconfig          | 1 +
 drivers/staging/most/mostcore/Kconfig | 1 +
 2 files changed, 2 insertions(+)
drivers/staging/most/Kconfig +1 -0
index d50de03de7b98972..0b9b9b539f70562d 100644
@@ -1,5 +1,6 @@
 menuconfig MOST
         tristate "MOST driver"
+	depends on HAS_DMA
         select MOSTCORE
         default n
         ---help---
drivers/staging/most/mostcore/Kconfig +1 -0
index 38abf1b21b6623c7..47172546d7280ee6 100644
@@ -4,6 +4,7 @@
 
 config MOSTCORE
 	tristate "MOST Core"
+	depends on HAS_DMA
 
 	---help---
 	  Say Y here if you want to enable MOST support.
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Tue, 1 Sep 2015 22:05:58 +0200 Geert Uytterhoeven <[email protected]>…

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/staging/most/mostcore/mostcore.ko] undefined!

As all MOST sub drivers use DMA functionality, add a dependency on HAS_DMA to MOSTCORE, and to MOST, which selects MOSTCORE.

Quoted 28 lines
---
 drivers/staging/most/Kconfig          | 1 +
 drivers/staging/most/mostcore/Kconfig | 1 +
 2 files changed, 2 insertions(+)
drivers/staging/most/Kconfig +1 -0
index d50de03de7b98972..0b9b9b539f70562d 100644
@@ -1,5 +1,6 @@
 menuconfig MOST
         tristate "MOST driver"
+	depends on HAS_DMA
         select MOSTCORE
         default n
         ---help---
drivers/staging/most/mostcore/Kconfig +1 -0
index 38abf1b21b6623c7..47172546d7280ee6 100644
@@ -4,6 +4,7 @@
 
 config MOSTCORE
 	tristate "MOST Core"
+	depends on HAS_DMA
 
 	---help---
 	  Say Y here if you want to enable MOST support.