Skip to contentSkip to conversation

ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module

PATCH In review Anand Moon 2 participants 4 messages Sep 3, 2015 – Sep 4, 2015

Subsystems (2)
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH 1/1 ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module

S3C2410_WATCHDOG watchdog drivers should not be loaded automatically, but only if a watchdog daemon is installed.

---
 arch/arm/configs/exynos_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/exynos_defconfig +1 -1
index aaf7aa4..b5d382e 100644
@@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
-CONFIG_S3C2410_WATCHDOG=y
+CONFIG_S3C2410_WATCHDOG=m
 CONFIG_MFD_CROS_EC=y
 CONFIG_MFD_CROS_EC_I2C=y
 CONFIG_MFD_CROS_EC_SPI=y
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Anand Moon

S3C2410_WATCHDOG watchdog drivers should not be loaded automatically, but only if a watchdog daemon is installed.

First of all: why?

Secondly: even as a module driver could be loaded automatically to match enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it does not hurt - watchdog should be inactive:

s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq disabled

Best regards,
Krzysztof

Quoted 20 lines
---
 arch/arm/configs/exynos_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/exynos_defconfig +1 -1
index aaf7aa4..b5d382e 100644
@@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
-CONFIG_S3C2410_WATCHDOG=y
+CONFIG_S3C2410_WATCHDOG=m
 CONFIG_MFD_CROS_EC=y
 CONFIG_MFD_CROS_EC_I2C=y
 CONFIG_MFD_CROS_EC_SPI=y
author
#2 lore raw

Hi Krzysztof

Quoted 22 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

S3C2410_WATCHDOG watchdog drivers should not be loaded automatically, but only if a watchdog daemon is installed.

First of all: why?

Secondly: even as a module driver could be loaded automatically to match enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it does not hurt - watchdog should be inactive:

s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq disabled

Best regards,
Krzysztof

Quoted 6 lines
---
 arch/arm/configs/exynos_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
arch/arm/configs/exynos_defconfig +0 -0
index aaf7aa4..b5d382e 100644

arch/arm/configs/exynos_defconfig CONFIG_CPU_THERMAL=y · line 107

Quoted 8 lines
arch/arm/configs/exynos_defconfig +1 -1
@@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
-CONFIG_S3C2410_WATCHDOG=y
+CONFIG_S3C2410_WATCHDOG=m
 CONFIG_MFD_CROS_EC=y
 CONFIG_MFD_CROS_EC_I2C=y
 CONFIG_MFD_CROS_EC_SPI=y

All the watchdog drivers are blacklisted not to be loaded by the ubuntu. Their are some configurable parameters which get configured while loading of the module using watchdog daemon.
Watchdog service will reconfigure watchdog driver while loading.

-Anand Moon

Quoted 1 line
#3 lore raw
Quoted 37 lines · Anand Moon

Hi Krzysztof

Quoted 33 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

S3C2410_WATCHDOG watchdog drivers should not be loaded automatically, but only if a watchdog daemon is installed.

First of all: why?

Secondly: even as a module driver could be loaded automatically to match enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it does not hurt - watchdog should be inactive:

s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq disabled

Best regards,
Krzysztof

Quoted 17 lines
---
 arch/arm/configs/exynos_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/configs/exynos_defconfig +1 -1
index aaf7aa4..b5d382e 100644
@@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y
 CONFIG_THERMAL_EMULATION=y
 CONFIG_EXYNOS_THERMAL=y
 CONFIG_WATCHDOG=y
-CONFIG_S3C2410_WATCHDOG=y
+CONFIG_S3C2410_WATCHDOG=m
 CONFIG_MFD_CROS_EC=y
Quoted 8 lines
Quoted 3 lines

arch/arm/configs/exynos_defconfig CONFIG_CPU_THERMAL=y · line 107

Quoted 3 lines
arch/arm/configs/exynos_defconfig +0 -0
 CONFIG_MFD_CROS_EC_I2C=y
 CONFIG_MFD_CROS_EC_SPI=y

All the watchdog drivers are blacklisted not to be loaded by the ubuntu. Their are some configurable parameters which get configured while loading of the module using watchdog daemon.
Watchdog service will reconfigure watchdog driver while loading.

Thank you for clarification. First of all such information (that Ubuntu requires it) should be put in commit message.

This looks like a requirement specific for Ubuntu. For example on Arch these modules are not blacklisted. I don't know how this is handled on Debian or Fedora.

Other defconfigs (including multi_v7) make these modules built-in.

Summarizing I am not convinced that the change is necessary. Having everything built-in makes testing exynos defconfig easier because some you just upload zImage and DTB to the testing board. With modules you have to prepare the initramfs/initrd (e.g. for network boot).

Best regards,
Krzysztof