Skip to contentSkip to conversation

ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

PATCH In review Anand Moon 3 participants 7 messages Sep 3, 2015 – Sep 4, 2015

Subsystems (2)
lore
Share & tools
lore

Anand Moon

author
#0 lore raw

PATCH v7 1/1 ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

---
Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_LEDS_TRIGGER_TIMER
CONFIG_TRIGGER_GPIO
fixed the From address
fixed the commit message.

---
 arch/arm/configs/exynos_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/configs/exynos_defconfig +6 -0
index 9504e77..bd6b7f7 100644
@@ -163,6 +163,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

Quoted 35 lines

---
Changes from last version
dropped following option.
CONFIG_LEDS_CLASS_FLASH
CONFIG_TRIGGER_ONESHOT
CONFIG_LEDS_TRIGGER_TIMER
CONFIG_TRIGGER_GPIO
fixed the From address
fixed the commit message.

---
 arch/arm/configs/exynos_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/configs/exynos_defconfig +6 -0
index 9504e77..bd6b7f7 100644
@@ -163,6 +163,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
 CONFIG_MMC_DW=y
 CONFIG_MMC_DW_IDMAC=y
 CONFIG_MMC_DW_EXYNOS=y
+CONFIG_NEW_LEDS=y
+CONFIG_LEDS_CLASS=y
+CONFIG_LEDS_GPIO=y
+CONFIG_LEDS_PWM=y
+CONFIG_LEDS_TRIGGERS=y
+CONFIG_LEDS_TRIGGER_HEARTBEAT=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX77686=y
 CONFIG_RTC_DRV_MAX77802=y
#2 lore raw

Hello Krzysztof,

Quoted 9 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version.

Quoted 7 lines

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America
author
#3 lore raw

Hi All,

Quoted 7 lines · Javier Martinez Canillas

Hello Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

Quoted 17 lines
Quoted 5 lines

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version.

Quoted 7 lines

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

I give up. I will not resend any patch.
I don't own this changes.

sorry for the noise.

-Anand Moon

Quoted 5 lines

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

author
#4 lore raw
In reply to Javier Martinez Canillas

Hi All,

Quoted 7 lines · Javier Martinez Canillas

Hello Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

Quoted 16 lines
Quoted 5 lines

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version.

Quoted 7 lines

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

Just of the records. I you agree with following commit message I will resend the patch.
------------------------------------------------------
Exynos boards support GPIO and PWM based LEDs

Odroid boards support led activity to indicate the various status Red led - power: hooked up to 5V power
Blue led - alive Solid light : u-boot is running
flashing : Kernel is running (heart beat)
-------------------------------------------------------
If you want to add some thing more please suggest me.

Earlier I was just frustrated.

-Anand Moon

Quoted 5 lines

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

#5 lore raw
Quoted 33 lines · Anand Moon

Hi All,

Quoted 7 lines · Javier Martinez Canillas

Hello Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

Quoted 16 lines
Quoted 5 lines

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version.

Quoted 7 lines

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

Just of the records. I you agree with following commit message I will resend the patch.
------------------------------------------------------
Exynos boards support GPIO and PWM based LEDs

Quoted 8 lines

Odroid boards support led activity to indicate the various status Red led - power: hooked up to 5V power
Blue led - alive Solid light : u-boot is running
flashing : Kernel is running (heart beat)
-------------------------------------------------------
If you want to add some thing more please suggest me.

Earlier I was just frustrated.

That commit message looks better. Anyway I applied the patch with changed message. You can find it here:
https://github.com/krzk/linux/commit/8b14e57ae423b676873e542944ed8714be211ded

although it is not pushed to the for-next branch because we are at merge window.

Best regards,
Krzysztof

author
#6 lore raw

Hi Krzysztof,

Quoted 47 lines · Krzysztof Kozlowski
Quoted 33 lines · Anand Moon

Hi All,

Quoted 7 lines · Javier Martinez Canillas

Hello Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Anand Moon

Earlier design of the LED for Odroid XU3 was using gpio-leds Now It was change to using both pwm-leds and gpio-leds.

Quoted 16 lines
Quoted 5 lines

It is still not a reason for this change. gpio-leds were not enabled before. This could be a valid reason of adding LEDS_PWM to existing config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Agreed, also the commit message doesn't explain why the heartbeat LED trigger is enabled as I mentioned in the previous version.

Quoted 7 lines

Actually I gave up on this and I wanted to change the commit message on myself when applying. But discussion was brought up again so... clearly we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

Just of the records. I you agree with following commit message I will resend the patch.
------------------------------------------------------
Exynos boards support GPIO and PWM based LEDs

Quoted 8 lines

Odroid boards support led activity to indicate the various status Red led - power: hooked up to 5V power
Blue led - alive Solid light : u-boot is running
flashing : Kernel is running (heart beat)
-------------------------------------------------------
If you want to add some thing more please suggest me.

Earlier I was just frustrated.

That commit message looks better. Anyway I applied the patch with changed message. You can find it here:
https://github.com/krzk/linux/commit/8b14e57ae423b676873e542944ed8714be211ded

Quoted 6 lines

although it is not pushed to the for-next branch because we are at merge window.

Best regards,
Krzysztof

Thanks you very much.

-Anand Moon