acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device()
PATCH 1/1 acpi-dma: Use ACPI_COMPANION() instead of acpi_bus_get_device()
Get pointer to the struct acpi_device by using ACPI_COMPANION() macro. This is more efficient than using ACPI_HANDLE() and acpi_bus_get_device().
Signed-off-by Jarkko Nikula <[email protected]>
--- drivers/dma/acpi-dma.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/dma/acpi-dma.c +5 -6
@@ -160,10 +160,8 @@ int acpi_dma_controller_register(struct device *dev,return -EINVAL ;/* Check if the device was enumerated by ACPI */ -if (!ACPI_HANDLE (dev)) -return -EINVAL ; - -if (acpi_bus_get_device (ACPI_HANDLE (dev), &adev)) + adev =ACPI_COMPANION (dev); +if (!adev)return -EINVAL ; adma =kzalloc (sizeof (*adma),GFP_KERNEL );
@@ -358,10 +356,11 @@ struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,int found;/* Check if the device was enumerated by ACPI */ -if (!dev || !ACPI_HANDLE (dev)) +if (!dev)return ERR_PTR (-ENODEV ); -if (acpi_bus_get_device (ACPI_HANDLE (dev), &adev)) + adev =ACPI_COMPANION (dev); +if (!adev)return ERR_PTR (-ENODEV );memset (&pdata,0 ,sizeof (pdata));
Signature · 1 line
2.5.1
Quoted 4 lines · Jarkko Nikula
Get pointer to the struct
acpi_deviceby usingACPI_COMPANION()macro. This is more efficient than usingACPI_HANDLE()andacpi_bus_get_device().Signed-off-by Jarkko Nikula <[email protected]>
Quoted 36 lines
--- drivers/dma/acpi-dma.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)drivers/dma/acpi-dma.c +5
-6@@ -160,10 +160,8 @@ int acpi_dma_controller_register(struct device *dev,return -EINVAL ;/* Check if the device was enumerated by ACPI */ -if (!ACPI_HANDLE (dev)) -return -EINVAL ; - -if (acpi_bus_get_device (ACPI_HANDLE (dev), &adev)) + adev =ACPI_COMPANION (dev); +if (!adev)return -EINVAL ; adma =kzalloc (sizeof (*adma),GFP_KERNEL );@@ -358,10 +356,11 @@ struct dma_chan *acpi_dma_request_slave_chan_by_index(struct device *dev,int found;/* Check if the device was enumerated by ACPI */ -if (!dev || !ACPI_HANDLE (dev)) +if (!dev)return ERR_PTR (-ENODEV ); -if (acpi_bus_get_device (ACPI_HANDLE (dev), &adev)) + adev =ACPI_COMPANION (dev); +if (!adev)return ERR_PTR (-ENODEV );memset (&pdata,0 ,sizeof (pdata));
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
Quoted 2 lines · Jarkko Nikula
Get pointer to the struct
acpi_deviceby usingACPI_COMPANION()macro. This is more efficient than usingACPI_HANDLE()andacpi_bus_get_device().
Applied aftre fixing the right subsystem name. Please ensure you send patches with right tags
Signature · 1 line
~Vinod