Skip to contentSkip to conversation

tcmode-default: Set gcc 5.2 as the default

PATCH In review Richard Purdie 4 participants 7 messages Sep 4, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tcmode-default: Set gcc 5.2 as the default

gcc 5.2 is now working in all the places we test it in, its been in testing for quite some time. Time to make it the default (we have some room in M4 for any other bugfixes). Its easy to switch back to 4.9, we should really remove 4.8 at this point (to meta-oe?).

meta/conf/distro/include/tcmode-default.inc +1 -1
index fabd347..f34cd22 100644
@@ -22,7 +22,7 @@ PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-initial = "${TCLIBC}-initial"
 PREFERRED_PROVIDER_virtual/nativesdk-${SDK_PREFIX}libc-initial = "nativesdk-${TCLIBC}-initial"
 PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
 
-GCCVERSION ?= "4.9%"
+GCCVERSION ?= "5.2%"
 SDKGCCVERSION ?= "${GCCVERSION}"
 BINUVERSION ?= "2.25%"
 GDBVERSION ?= "7.9%"
#1 lore raw

meta/conf/distro/include/tcmode-default.inc PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-initial = "${TCLIBC}-initial" · line 25

Quoted 5 lines · Richard Purdie
meta/conf/distro/include/tcmode-default.inc +1 -1
-GCCVERSION ?= "4.9%"
+GCCVERSION ?= "5.2%"

a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be 6.x

#2 lore raw
Quoted 4 lines · Khem Raj

a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be
6.x

To be honest I'd prefer *any* change to the compiler beyond eg 5.2.0 -> 5.2.1 to be explicit. I think we've all seen enough breakage from a "bug fix" release to know that it needs a proper test.

Ross

#4 lore raw
In reply to Khem Raj
Quoted 7 lines · Khem Raj

meta/conf/distro/include/tcmode-default.inc PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-initial = "${TCLIBC}-initial" · line 25

Quoted 4 lines · Richard Purdie
meta/conf/distro/include/tcmode-default.inc +1 -1
-GCCVERSION ?= "4.9%"
+GCCVERSION ?= "5.2%"

a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be 6.x

I'm not sure this would be a good idea. We have had 4.8 alongside 4.9 and can imagine doing something like that with newer 5.x releases depending on how they work out. I doubt 5.2% hurts anything, apart from needing to tweak that file slightly more often...

Cheers,

Richard

#5 lore raw
Quoted 9 lines · Richard Purdie
Quoted 7 lines · Khem Raj

meta/conf/distro/include/tcmode-default.inc PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-initial = "${TCLIBC}-initial" · line 25

Quoted 4 lines · Richard Purdie
meta/conf/distro/include/tcmode-default.inc +1 -1
-GCCVERSION ?= "4.9%"
+GCCVERSION ?= "5.2%"

a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be 6.x

Quoted 4 lines

I'm not sure this would be a good idea. We have had 4.8 alongside 4.9 and can imagine doing something like that with newer 5.x releases depending on how they work out. I doubt 5.2% hurts anything, apart from needing to tweak that file slightly more often...

But that was before GCC changed versioning scheme in 5, see "Version Numbering Scheme for GCC 5 and Up" section in
https://gcc.gnu.org/develop.html

Having 5.1 alongside 5.2 isn't the same as 4.8 alongside 4.9 was.

I agree with Khem.

Ross: I agree that even small point release has to be tested, but this variable is useful only to have multiple versions alongside each other, which shouldn't be the case for 5.1 and 5.2 (or even 5.2.0 and 5.2.1 in your example).

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw
In reply to Burton, Ross
Quoted 10 lines · Ross

On 4 September 2015 at 16:29, Khem Raj <[email protected] <mailto:[email protected]>> wrote:
a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be 6.x

To be honest I'd prefer *any* change to the compiler beyond eg 5.2.0 -> 5.2.1 to be explicit. I think we've all seen enough breakage from a "bug fix" release to know that it needs a proper test.

well to put it in simple way gcc has changes its release numbers so

4.9.x is same as 5.x now ( bug fix release) . Does that help

Quoted 1 line

Ross

#6 lore raw
In reply to Richard Purdie
Quoted 12 lines · Richard Purdie
Quoted 7 lines · Khem Raj

meta/conf/distro/include/tcmode-default.inc PREFERRED_PROVIDER_virtual/${TARGET_PREFIX}libc-initial = "${TCLIBC}-initial" · line 25

Quoted 4 lines · Richard Purdie
meta/conf/distro/include/tcmode-default.inc +1 -1
-GCCVERSION ?= "4.9%"
+GCCVERSION ?= "5.2%"

a small nit. Make it 5.% to logically indicate that 5.x is a bug fix release and next big upgrade will be 6.x

Quoted 5 lines

I'm not sure this would be a good idea. We have had 4.8 alongside 4.9 and can imagine doing something like that with newer 5.x releases depending on how they work out. I doubt 5.2% hurts anything, apart from needing to tweak that file slightly more often…

I was asking so that it gets to people that 5.1 and 5.2 are not major release anymore instead 5.x and 6.x
will be major release in future. So there will never be 5.2 and 5.3 simultaneously existing but 5.2 and 6.0 might. So it just reflects the upstream release model change. We can always change the minor as well there is no other technical advantage of using 5.%

Quoted 6 lines

Cheers,

Richard