Skip to contentSkip to conversation

Staging: rtl8712: Replace memcpy by ether_addr_copy

PATCH NAK Shraddha Barke 2 participants 6 messages Sep 6, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Staging: rtl8712: Replace memcpy by ether_addr_copy

This patch replaces memcpy by ethr_addr_copy

The change was made using Coccinelle

@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

---
 drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +1 -1
index 77f01bf..76c1cfe 100644
@@ -167,7 +167,7 @@ static int mp_start_test(struct _adapter *padapter)
 	int res = _SUCCESS;
 
 	/* 3 1. initialize a new struct wlan_bssid_ex */
-	memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
+	ether_addr_copy(bssid.MacAddress, pmppriv->network_macaddr);
 	bssid.Ssid.SsidLength = 16;
 	memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
 		bssid.Ssid.SsidLength);
Signature · 1 line
2.1.4
#1 lore raw

PATCH 2/3 Staging: rtl8192e: Replace memcpy by ethr_addr_copy

The patch replaces memcpy with ethr_addr_copy

The changes were applied using the following coccinelle rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

---
 drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_softmac_wx.c +2 -2
index 86f52ac..cf243fe 100644
@@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
 
 		eth_zero_addr(wrqu->ap_addr.sa_data);
 	else
-		memcpy(wrqu->ap_addr.sa_data,
-		       ieee->current_network.bssid, ETH_ALEN);
+		ether_addr_copy(wrqu->ap_addr.sa_data,
+				ieee->current_network.bssid);
 
 	spin_unlock_irqrestore(&ieee->lock, flags);
 
Signature · 1 line
2.1.4
#2 lore raw

Re: [PATCH 2/3] Staging: rtl8192e: Replace memcpy by ethr_addr_copy

Quoted 8 lines · Shraddha Barke

The patch replaces memcpy with ethr_addr_copy

The changes were applied using the following coccinelle rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

Quoted 4 lines
---
  drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

The same comments apply as in patch 1/3. NACK.

Larry

Quoted 17 lines
drivers/staging/rtl8192e/rtllib_softmac_wx.c +2 -2
index 86f52ac..cf243fe 100644
@@ -122,8 +122,8 @@ int rtllib_wx_get_wap(struct rtllib_device *ieee,
 
  		eth_zero_addr(wrqu->ap_addr.sa_data);
  	else
-		memcpy(wrqu->ap_addr.sa_data,
-		       ieee->current_network.bssid, ETH_ALEN);
+		ether_addr_copy(wrqu->ap_addr.sa_data,
+				ieee->current_network.bssid);
 
  	spin_unlock_irqrestore(&ieee->lock, flags);
 
#3 lore raw

PATCH 3/3 Staging: rtl8192u: r8192U_core.c: Replace memcpy with eth_addr_copy

In reply to Shraddha Barke

This patch replaces memcpy with eth_addr_copy

The changes were applied using the following coccinelle rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

---
 drivers/staging/rtl8192u/r8192U_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_core.c +1 -1
index 6f6fe38..577d3a4 100644
@@ -3430,7 +3430,7 @@ static int r8192_set_mac_adr(struct net_device *dev, void *mac)
 
 	down(&priv->wx_sem);
 
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+	ether_addr_copy(dev->dev_addr, addr->sa_data);
 
 	schedule_work(&priv->reset_wq);
 	up(&priv->wx_sem);
Signature · 1 line
2.1.4
#4 lore raw

Re: [PATCH 3/3] Staging: rtl8192u: r8192U_core.c: Replace memcpy with eth_addr_copy

Quoted 19 lines · Shraddha Barke

This patch replaces memcpy with eth_addr_copy

The changes were applied using the following coccinelle rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

---
  drivers/staging/rtl8192u/r8192U_core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/r8192U_core.c +0 -0
index 6f6fe38..577d3a4 100644

drivers/staging/rtl8192u/r8192U_core.c static int r8192_set_mac_adr(struct net_device *dev, void *mac) · line 3436

Quoted 8 lines
drivers/staging/rtl8192u/r8192U_core.c +1 -1
@@ -3430,7 +3430,7 @@ static int r8192_set_mac_adr(struct net_device *dev, void *mac)
 
  	down(&priv->wx_sem);
 
-	memcpy(dev->dev_addr, addr->sa_data, ETH_ALEN);
+	ether_addr_copy(dev->dev_addr, addr->sa_data);
 
  	schedule_work(&priv->reset_wq);
  	up(&priv->wx_sem);

This patch has the same problems as do both patches 1 and 2.

NACK.

Larry

#5 lore raw
In reply to Shraddha Barke
Quoted 4 lines · Shraddha Barke

This patch replaces memcpy by ethr_addr_copy

The change was made using Coccinelle

Quoted 8 lines

@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

---
  drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Your commit message has a typo.

More seriously, ether_addr_copy() requires that both arguments be u16 aligned. This condition is not hard to meet, but I see no indication in your commit message that you have checked this requirement. As a result, I must NACK this patch.

Coccinelle is a wonderful tool, but the user must exercise judgment when applying the results.

Larry

Larry

Quoted 15 lines
drivers/staging/rtl8712/rtl871x_mp_ioctl.c +1 -1
index 77f01bf..76c1cfe 100644
@@ -167,7 +167,7 @@ static int mp_start_test(struct _adapter *padapter)
  	int res = _SUCCESS;
 
  	/* 3 1. initialize a new struct wlan_bssid_ex */
-	memcpy(bssid.MacAddress, pmppriv->network_macaddr, ETH_ALEN);
+	ether_addr_copy(bssid.MacAddress, pmppriv->network_macaddr);
  	bssid.Ssid.SsidLength = 16;
  	memcpy(bssid.Ssid.Ssid, (unsigned char *)"mp_pseudo_adhoc",
  		bssid.Ssid.SsidLength);