Skip to contentSkip to conversation

spi: cadence_qspi: Ensure check for max frequency in place

PATCH Superseded Chin Liang See 2 participants 3 messages Sep 8, 2015 – Sep 10, 2015 SPI

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 3/4 spi: cadence_qspi: Ensure check for max frequency in place

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
---
 drivers/spi/cadence_qspi.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/spi/cadence_qspi.c +5 -0
index 8c0f7dd..f430b5d 100644
@@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
 	struct cadence_spi_priv *priv = dev_get_priv(bus);
 	int err;
 
+	if (hz > plat->max_hz) {
+		hz = plat->max_hz;
+		puts("SF: Default to maximum supported SCLK frequency\n");
+	}
+
 	/* Disable QSPI */
 	cadence_qspi_apb_controller_disable(priv->regbase);
 
Signature · 1 line
1.7.7.4
#1 lore raw

PATCH 3/4 spi: cadence_qspi: Ensure check for max frequency in place

Quoted 20 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
---
 drivers/spi/cadence_qspi.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/spi/cadence_qspi.c +0 -0
index 8c0f7dd..f430b5d 100644

drivers/spi/cadence_qspi.c static int cadence_spi_set_speed(struct udevice *bus, uint hz) · line 132

Quoted 6 lines
drivers/spi/cadence_qspi.c +3 -0
@@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
        struct cadence_spi_priv *priv = dev_get_priv(bus);
        int err;
 
+       if (hz > plat->max_hz) {
+               hz = plat->max_hz;
+               puts("SF: Default to maximum supported SCLK frequency\n");

This print mayn't require just assign plat->max_hz enough.

drivers/spi/cadence_qspi.c static int cadence_spi_set_speed(struct udevice *bus, uint hz) · line 136

Quoted 4 lines
drivers/spi/cadence_qspi.c +2 -0
+       }
+
        /* Disable QSPI */
        cadence_qspi_apb_controller_disable(priv->regbase);

thanks!

Signature · 1 line
Jagan | openedev.
#2 lore raw

PATCH 3/4 spi: cadence_qspi: Ensure check for max frequency in place

Hi,

Quoted 24 lines · Jagan Teki
Quoted 23 lines · Chin Liang See

Ensure the intended SCLK frequency not exceeding the maximum frequency. If that happen, SCLK will set to maximum frequency.

Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Vikas Manocha <[email protected]>
Cc Jagannadh Teki <[email protected]>
Cc Pavel Machek <[email protected]>
---
 drivers/spi/cadence_qspi.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/spi/cadence_qspi.c +0 -0
index 8c0f7dd..f430b5d 100644
@@ -127,6 +127,11 @@ static int cadence_spi_set_speed(struct udevice *bus, uint hz)
        struct cadence_spi_priv *priv = dev_get_priv(bus);
        int err;
 
Quoted 5 lines

drivers/spi/cadence_qspi.c static int cadence_spi_set_speed(struct udevice *bus, uint hz) · line 132

Quoted 3 lines
drivers/spi/cadence_qspi.c +3 -0
+       if (hz > plat->max_hz) {
+               hz = plat->max_hz;
+               puts("SF: Default to maximum supported SCLK frequency\n");

This print mayn't require just assign plat->max_hz enough.

Sure, I can update that.

Thanks
Chin Liang

Quoted 9 lines

drivers/spi/cadence_qspi.c static int cadence_spi_set_speed(struct udevice *bus, uint hz) · line 136

Quoted 4 lines
drivers/spi/cadence_qspi.c +2 -0
+       }
+
        /* Disable QSPI */
        cadence_qspi_apb_controller_disable(priv->regbase);

thanks!