vfs: remove stale comment in inode_operations
PATCH 1/1 vfs: remove stale comment in inode_operations
The big warning comment that is currently at the end of struct inode_operations was added as part of this commit:
4aa7c6346be3 ("vfs: add i_op->dentry_open()")
It was added to warn people not to use the newly added 'dentry_open' function pointer.
This function pointer was removed as part of this commit:
4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and
f_inode to the underlay")
The comment was left behind and now refers to nothing, so remove it.
--- include/linux/fs.h | 2 -- 1 file changed, 2 deletions(-)
include/linux/fs.h +0 -2
@@ -1679,8 +1679,6 @@ struct inode_operations { umode_t create_mode, int *opened);int (*tmpfile) (struct inode *,struct dentry *,umode_t );int (*set_acl)(struct inode *,struct posix_acl *,int ); - -/* WARNING: probably going away soon, do not use! */ }____cacheline_aligned ; ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,
Signature · 1 line
2.1.0
Quoted 25 lines · Ross Zwisler
The big warning comment that is currently at the end of struct
inode_operationswas added as part of this commit:
4aa7c6346be3("vfs: addi_op->dentry_open()")It was added to warn people not to use the newly added '
dentry_open' function pointer.This function pointer was removed as part of this commit:
4bacc9c9234c("overlayfs: Makef_pathalways point to the overlay and
f_inodeto the underlay")The comment was left behind and now refers to nothing, so remove it.
Signed-off-by Ross Zwisler <[email protected]>--- include/linux/fs.h | 2 -- 1 file changed, 2 deletions(-)include/linux/fs.h +0
-0
include/linux/fs.h struct inode_operations { · line 1684
Quoted 8 lines
include/linux/fs.h +0
-2@@ -1679,8 +1679,6 @@ struct inode_operations { umode_t create_mode, int *opened);int (*tmpfile) (struct inode *,struct dentry *,umode_t );int (*set_acl)(struct inode *,struct posix_acl *,int ); - -/* WARNING: probably going away soon, do not use! */ }____cacheline_aligned ; ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,
Ping?
Jan Kara
reviewerQuoted 33 lines · Ross Zwisler
Quoted 32 lines · Ross Zwisler
The big warning comment that is currently at the end of struct
inode_operationswas added as part of this commit:
4aa7c6346be3("vfs: addi_op->dentry_open()")It was added to warn people not to use the newly added '
dentry_open' function pointer.This function pointer was removed as part of this commit:
4bacc9c9234c("overlayfs: Makef_pathalways point to the overlay and
f_inodeto the underlay")The comment was left behind and now refers to nothing, so remove it.
Signed-off-by Ross Zwisler <[email protected]>--- include/linux/fs.h | 2 -- 1 file changed, 2 deletions(-)include/linux/fs.h +0
-2@@ -1679,8 +1679,6 @@ struct inode_operations { umode_t create_mode, int *opened);int (*tmpfile) (struct inode *,struct dentry *,umode_t );int (*set_acl)(struct inode *,struct posix_acl *,int ); - -/* WARNING: probably going away soon, do not use! */ }____cacheline_aligned ;
Quoted 3 lines
include/linux/fs.h struct inode_operations { · line 1684
Quoted 1 line
include/linux/fs.h +0
-0ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector,Ping?
Probably should go to Al. Added to CC.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR