openssh: CVE-2015-6563 CVE-2015-6564 CVE-2015-6565
PATCH 1/1 openssh: CVE-2015-6563 CVE-2015-6564 CVE-2015-6565
From: Armin Kuster <[email protected]>
three security fixes.
CVE-2015-6563 (Low) openssh: Privilege separation weakness related to PAM support CVE-2015-6564 (medium) openssh: Use-after-free bug related to PAM support CVE-2015-6565 (High) openssh: Incorrectly set TTYs to be world-writable
--- .../openssh/openssh/CVE-2015-6563.patch | 36 ++++++++++++++++++++++ .../openssh/openssh/CVE-2015-6564.patch | 34 ++++++++++++++++++++ .../openssh/openssh/CVE-2015-6565.patch | 35 +++++++++++++++++++++ meta/recipes-connectivity/openssh/openssh_6.7p1.bb | 6 +++- 4 files changed, 110 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-6564.patch create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-6565.patch
meta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch new file +36 -0
@@ -0,0 +1,36 @@ +CVE-2015-6563 + +Don't resend username to PAM; it already has it. +Pointed out by Moritz Jodeit; ok dtucker@ + +Upstream-Status: Backport +https://github.com/openssh/openssh-portable/commit/d4697fe9a28dab7255c60433e4dd23cf7fce8a8b + +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/monitor.c +=================================================================== +--- openssh-6.7p1.orig/monitor.c ++++ openssh-6.7p1/monitor.c +@@ -1046,9 +1046,7 @@ extern KbdintDevice sshpam_device; + int + mm_answer_pam_init_ctx(int sock, Buffer *m) + { +- + debug3("%s", __func__); +- authctxt->user = buffer_get_string(m, NULL); + sshpam_ctxt = (sshpam_device.init_ctx)(authctxt); + sshpam_authok = NULL; + buffer_clear(m); +Index: openssh-6.7p1/monitor_wrap.c +=================================================================== +--- openssh-6.7p1.orig/monitor_wrap.c ++++ openssh-6.7p1/monitor_wrap.c +@@ -826,7 +826,6 @@ mm_sshpam_init_ctx(Authctxt *authctxt) + + debug3("%s", __func__); + buffer_init(&m); +- buffer_put_cstring(&m, authctxt->user); + mm_request_send(pmonitor->m_recvfd, MONITOR_REQ_PAM_INIT_CTX, &m); + debug3("%s: waiting for MONITOR_ANS_PAM_INIT_CTX", __func__); + mm_request_receive_expect(pmonitor->m_recvfd, MONITOR_ANS_PAM_INIT_CTX, &m);
meta/recipes-connectivity/openssh/openssh/CVE-2015-6564.patch new file +34 -0
@@ -0,0 +1,34 @@ +CVE-2015-6564 + + set sshpam_ctxt to NULL after free + + Avoids use-after-free in monitor when privsep child is compromised. + Reported by Moritz Jodeit; ok dtucker@ + +Upstream-Status: Backport +https://github.com/openssh/openssh-portable/commit/5e75f5198769056089fb06c4d738ab0e5abc66f7 + +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/monitor.c +=================================================================== +--- openssh-6.7p1.orig/monitor.c ++++ openssh-6.7p1/monitor.c +@@ -1128,14 +1128,16 @@ mm_answer_pam_respond(int sock, Buffer * + int + mm_answer_pam_free_ctx(int sock, Buffer *m) + { ++ int r = sshpam_authok != NULL && sshpam_authok == sshpam_ctxt; + + debug3("%s", __func__); + (sshpam_device.free_ctx)(sshpam_ctxt); ++ sshpam_ctxt = sshpam_authok = NULL; + buffer_clear(m); + mm_request_send(sock, MONITOR_ANS_PAM_FREE_CTX, m); + auth_method = "keyboard-interactive"; + auth_submethod = "pam"; +- return (sshpam_authok == sshpam_ctxt); ++ return r; + } + #endif +
meta/recipes-connectivity/openssh/openssh/CVE-2015-6565.patch new file +35 -0
@@ -0,0 +1,35 @@ +CVE-2015-6565 openssh: Incorrectly set TTYs to be world-writable + +fix pty permissions; patch from Nikolay Edigaryev; ok deraadt + +Upstream-Status: Backport + +merged two changes into one. +[1] https://anongit.mindrot.org/openssh.git/commit/sshpty.c?id=a5883d4eccb94b16c355987f58f86a7dee17a0c2 +tighten permissions on pty when the "tty" group does not exist; pointed out by Corinna Vinschen; ok markus + +[2] https://anongit.mindrot.org/openssh.git/commit/sshpty.c?id=6f941396b6835ad18018845f515b0c4fe20be21a +fix pty permissions; patch from Nikolay Edigaryev; ok deraadt + +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/sshpty.c +=================================================================== +--- openssh-6.7p1.orig/sshpty.c ++++ openssh-6.7p1/sshpty.c +@@ -196,13 +196,8 @@ pty_setowner(struct passwd *pw, const ch + + /* Determine the group to make the owner of the tty. */ + grp = getgrnam("tty"); +- if (grp) { +- gid = grp->gr_gid; +- mode = S_IRUSR | S_IWUSR | S_IWGRP; +- } else { +- gid = pw->pw_gid; +- mode = S_IRUSR | S_IWUSR | S_IWGRP | S_IWOTH; +- } ++ gid = (grp != NULL) ? grp->gr_gid : pw->pw_gid; ++ mode = (grp != NULL) ? 0620 : 0600; + + /* + * Change owner and mode of the tty as required.
meta/recipes-connectivity/openssh/openssh_6.7p1.bb +5 -1
@@ -21,7 +21,11 @@ SRC_URI = "ftp://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar. file://volatiles.99_sshd \ file://add-test-support-for-busybox.patch \ file://run-ptest \ - file://auth2-none.c-avoid-authenticate-empty-passwords-to-m.patch" + file://auth2-none.c-avoid-authenticate-empty-passwords-to-m.patch \ + file://CVE-2015-6563.patch \ + file://CVE-2015-6564.patch \ + file://CVE-2015-6565.patch \ + " PAM_SRC_URI = "file://sshd"
Signature · 1 line
2.3.5
Quoted 4 lines · Armin Kuster
From: Armin Kuster <[email protected]>
three security fixes.
Quoted 8 lines
CVE-2015-6563 (Low) openssh: Privilege separation weakness related to PAM support
CVE-2015-6564 (medium) openssh: Use-after-free bug related to PAM support
CVE-2015-6565 (High) openssh: Incorrectly set TTYs to be world -writableSigned-off-by Armin Kuster <[email protected]>
Patch queued in my joshuagl/fido-next tree - thanks!
Joshua
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=joshuagl/
fido-next
Quoted 177 lines
--- .../openssh/openssh/CVE-2015-6563.patch | 36 ++++++++++++++++++++++ .../openssh/openssh/CVE-2015-6564.patch | 34 ++++++++++++++++++++ .../openssh/openssh/CVE-2015-6565.patch | 35 +++++++++++++++++++++ meta/recipes-connectivity/openssh/openssh_6.7p1.bb | 6 +++- 4 files changed, 110 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE -2015-6563.patch create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE -2015-6564.patch create mode 100644 meta/recipes-connectivity/openssh/openssh/CVE-2015-6565.patch
(quoted diff) +0
-2-6563.patch b/meta/recipes-connectivity/openssh/openssh/CVE-2015 -6563.patchnew file mode 100644
index 0000000..19cea41meta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch new file +7
-0@@ -0,0 +1,36 @@ +CVE-2015-6563 + +Don't resend username to PAM; it already has it. +Pointed out by Moritz Jodeit; ok dtucker@ + +Upstream-Status: Backport +https://github.com/openssh/openssh-portable/commit/d4697fe9a28dab725
5c60433e4dd23cf7fce8a8bmeta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch new file +27
-0+ +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/monitor.c +=================================================================== +--- openssh-6.7p1.orig/monitor.c ++++ openssh-6.7p1/monitor.c +@@ -1046,9 +1046,7 @@ extern KbdintDevice sshpam_device; + int + mm_answer_pam_init_ctx(int sock, Buffer *m) + { +- + debug3("%s", __func__); +- authctxt->user = buffer_get_string(m, NULL); + sshpam_ctxt = (sshpam_device.init_ctx)(authctxt); + sshpam_authok = NULL; + buffer_clear(m); +Index: openssh-6.7p1/monitor_wrap.c +=================================================================== +--- openssh-6.7p1.orig/monitor_wrap.c ++++ openssh-6.7p1/monitor_wrap.c +@@ -826,7 +826,6 @@ mm_sshpam_init_ctx(Authctxt *authctxt) + + debug3("%s", __func__); + buffer_init(&m); +- buffer_put_cstring(&m, authctxt->user); + mm_request_send(pmonitor->m_recvfd,
MONITOR_REQ_PAM_INIT_CTX, &m);meta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch new file +1
-0+ debug3("%s: waiting for MONITOR_ANS_PAM_INIT_CTX",
__func__);meta/recipes-connectivity/openssh/openssh/CVE-2015-6563.patch new file +1
-0+ mm_request_receive_expect(pmonitor->m_recvfd,
MONITOR_ANS_PAM_INIT_CTX, &m);(quoted diff) +0
-2-6564.patch b/meta/recipes-connectivity/openssh/openssh/CVE-2015 -6564.patchnew file mode 100644
index 0000000..588d42dmeta/recipes-connectivity/openssh/openssh/CVE-2015-6564.patch new file +9
-0@@ -0,0 +1,34 @@ +CVE-2015-6564 + + set sshpam_ctxt to NULL after free + + Avoids use-after-free in monitor when privsep child is compromised. + Reported by Moritz Jodeit; ok dtucker@ + +Upstream-Status: Backport +https://github.com/openssh/openssh-portable/commit/5e75f519876905608
9fb06c4d738ab0e5abc66f7meta/recipes-connectivity/openssh/openssh/CVE-2015-6564.patch new file +25
-0+ +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/monitor.c +=================================================================== +--- openssh-6.7p1.orig/monitor.c ++++ openssh-6.7p1/monitor.c +@@ -1128,14 +1128,16 @@ mm_answer_pam_respond(int sock, Buffer * + int + mm_answer_pam_free_ctx(int sock, Buffer *m) + { ++ int r = sshpam_authok != NULL && sshpam_authok == sshpam_ctxt; + + debug3("%s", __func__); + (sshpam_device.free_ctx)(sshpam_ctxt); ++ sshpam_ctxt = sshpam_authok = NULL; + buffer_clear(m); + mm_request_send(sock, MONITOR_ANS_PAM_FREE_CTX, m); + auth_method = "keyboard-interactive"; + auth_submethod = "pam"; +- return (sshpam_authok == sshpam_ctxt); ++ return r; + } + #endif +(quoted diff) +0
-2-6565.patch b/meta/recipes-connectivity/openssh/openssh/CVE-2015 -6565.patchnew file mode 100644
index 0000000..42667b0meta/recipes-connectivity/openssh/openssh/CVE-2015-6565.patch new file +8
-0@@ -0,0 +1,35 @@ +CVE-2015-6565 openssh: Incorrectly set TTYs to be world-writable + +fix pty permissions; patch from Nikolay Edigaryev; ok deraadt + +Upstream-Status: Backport + +merged two changes into one. +[1] https://anongit.mindrot.org/openssh.git/commit/sshpty.c?id=a5883
d4eccb94b16c355987f58f86a7dee17a0c2
+tighten permissions on pty when the "tty" group does not exist; pointed out by Corinna Vinschen; ok markus
+
+[2] https://anongit.mindrot.org/openssh.git/commit/sshpty.c?id=6f941396b6835ad18018845f515b0c4fe20be21ameta/recipes-connectivity/openssh/openssh/CVE-2015-6565.patch new file +24
-0+fix pty permissions; patch from Nikolay Edigaryev; ok deraadt + +Signed-off-by: Armin Kuster <[email protected]> + +Index: openssh-6.7p1/sshpty.c +=================================================================== +--- openssh-6.7p1.orig/sshpty.c ++++ openssh-6.7p1/sshpty.c +@@ -196,13 +196,8 @@ pty_setowner(struct passwd *pw, const ch + + /* Determine the group to make the owner of the tty. */ + grp = getgrnam("tty"); +- if (grp) { +- gid = grp->gr_gid; +- mode = S_IRUSR | S_IWUSR | S_IWGRP; +- } else { +- gid = pw->pw_gid; +- mode = S_IRUSR | S_IWUSR | S_IWGRP | S_IWOTH; +- } ++ gid = (grp != NULL) ? grp->gr_gid : pw->pw_gid; ++ mode = (grp != NULL) ? 0620 : 0600; + + /* + * Change owner and mode of the tty as required.meta/recipes-connectivity/openssh/openssh_6.7p1.bb +0
-0@@ -21,7 +21,11 @@ SRC_URI = "ftp://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar.
file://volatiles.99_sshd \ file://add-test-support-for-busybox.patch \ file://run-ptest \meta/recipes-connectivity/openssh/openssh_6.7p1.bb +5
-3- file://auth2-none.c-avoid-authenticate-empty-passwords-to -m.patch" + file://auth2-none.c-avoid-authenticate-empty-passwords-to -m.patch \ + file://CVE-2015-6563.patch \ + file://CVE-2015-6564.patch \ + file://CVE-2015-6565.patch \ + " PAM_SRC_URI = "file://sshd"Signature · 2 lines
-- 2.3.5