Skip to contentSkip to conversation

lsb: add lsbinitscripts and util-linux rdepends

PATCH Superseded Alex Franco 3 participants 3 messages Sep 9, 2015 – Sep 24, 2015

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lsb: add lsbinitscripts and util-linux rdepends

Building a base image such as core-image-minimal with lsb and then attempting to source /lib/lsb/init-functions, then using the start _daemon function (to start a daemon, such as syslogd) fails, since /lib/lsb/init-functions use functions (incl. "daemon()") from file /etc/init.d/functions.lsbinitscripts, which is provided by package lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a binary provided by util-linux. So, both of these dependencies have been added to: recipes-extended/lsb/lsb_4.1.bb

[YOCTO #7732]

---
 meta/recipes-extended/lsb/lsb_4.1.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-extended/lsb/lsb_4.1.bb +3 -0
index b4ef98e..11b788f 100644
@@ -6,6 +6,9 @@ PR = "r2"
 
 # lsb_release needs getopt
 RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_getopt}"
+# lsb needs lsbinitscripts and util-linux
+RDEPENDS_${PN} += "lsbinitscripts \
+                   util-linux"
 
 LIC_FILES_CHKSUM = "file://README;md5=12da544b1a3a5a1795a21160b49471cf"
 
Signature · 1 line
1.8.4.5
#1 lore raw
Quoted 8 lines · Alex Franco

Building a base image such as core-image-minimal with lsb and then attempting to source /lib/lsb/init-functions, then using the start _daemon function (to start a daemon, such as syslogd) fails, since /lib/lsb/init-functions use functions (incl. "daemon()") from file /etc/init.d/functions.lsbinitscripts, which is provided by package lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a binary provided by util-linux. So, both of these dependencies have been added to: recipes-extended/lsb/lsb_4.1.bb

This line wrapping is... weird. :F

Quoted 1 line

[YOCTO #7732]

I can no longer reproduce the segfault I alluded to in that bug report; I guess I'll reopen it later if I see it again.

meta/recipes-extended/lsb/lsb_4.1.bb PR = "r2" · line 10

Quoted 8 lines
meta/recipes-extended/lsb/lsb_4.1.bb +1 -0
@@ -6,6 +6,9 @@ PR = "r2"
 
 # lsb_release needs getopt
 RDEPENDS_${PN} += "${VIRTUAL-RUNTIME_getopt}"
 
+# lsb needs lsbinitscripts and util-linux

Nitpick: does this comment accomplish anything?

meta/recipes-extended/lsb/lsb_4.1.bb PR = "r2" · line 11

Quoted 2 lines
meta/recipes-extended/lsb/lsb_4.1.bb +2 -0
+RDEPENDS_${PN} += "lsbinitscripts \
+                   util-linux"

Shouldn't the util-linux dependency exist in lsbinitscripts instead of lsb?

There's also a bash dependency in /etc/init.d/functions.lsbinitscripts that probably needs to get added, or a patch created to eliminate it. Should I file a new bug about it?

#2 lore raw
In reply to Alex Franco
Quoted 9 lines · Alex Franco

Building a base image such as core-image-minimal with lsb and then attempting to source /lib/lsb/init-functions, then using the start _daemon function (to start a daemon, such as syslogd) fails, since /lib/lsb/init-functions use functions (incl. "daemon()") from file /etc/init.d/functions.lsbinitscripts, which is provided by package lsbinitscripts. Running daemon() then calls /usr/bin/mountpoint, a binary provided by util-linux. So, both of these dependencies have been added to: recipes-extended/lsb/lsb_4.1.bb

Quoted 3 lines

[YOCTO #7732]

Mountpoint should be split so you don't bring all util-linux just for this.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750