Skip to contentSkip to conversation

bitbake-worker: Ensure pipe closure doesn't crash before killpg()

PATCH New Richard Purdie 1 participant 1 message Sep 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bitbake-worker: Ensure pipe closure doesn't crash before killpg()

If the pipe is closed, we want to ensure that we kill any child processes by triggering the sigterm handler before we exit. This code does that, hopefully avoiding the remaining process left behind issues on the autobuilder.

bitbake/bin/bitbake-worker +5 -1
index 0551d02..9a6b467 100755
@@ -87,7 +87,11 @@ def worker_child_fire(event, d):
     global worker_pipe
 
     data = "<event>" + pickle.dumps(event) + "</event>"
-    worker_pipe.write(data)
+    try:
+        worker_pipe.write(data)
+    except IOError:
+        sigterm_handler(None, None)
+        raise
 
 bb.event.worker_fire = worker_fire