pinctrl: core: handle pinctrl_get failure
Subsystems (2)
PATCH 1/1 pinctrl: core: handle pinctrl_get failure
Need to do error handling path when pinctrl_get fails. Also when pinctrl_get success, insert 'pctldev->node' to pinctrldev_list.
Signed-off-by Peng Fan <[email protected]>
Cc Linus Walleij <[email protected]>
--- drivers/pinctrl/core.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/pinctrl/core.c +6 -4
@@ -1753,10 +1753,6 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc, goto out_err; } -mutex_lock (&pinctrldev_list_mutex); -list_add_tail (&pctldev->node, &pinctrldev_list); -mutex_unlock (&pinctrldev_list_mutex); - pctldev->p =pinctrl_get (pctldev->dev);if (!IS_ERR (pctldev->p)) {
@@ -1776,8 +1772,14 @@ struct pinctrl_dev *pinctrl_register(struct pinctrl_desc *pctldesc, PINCTRL_STATE_SLEEP);if (IS_ERR (pctldev->hog_sleep))dev_dbg (dev,"failed to lookup the sleep state\n" ); + }else { + goto out_err; } +mutex_lock (&pinctrldev_list_mutex); +list_add_tail (&pctldev->node, &pinctrldev_list); +mutex_unlock (&pinctrldev_list_mutex); +pinctrl_init_device_debugfs (pctldev);return pctldev;
Signature · 1 line
1.8.4
Quoted 5 lines · Peng Fan
Need to do error handling path when
pinctrl_getfails. Also whenpinctrl_getsuccess, insert 'pctldev->node' topinctrldev_list.Signed-off-by Peng Fan <[email protected]>Cc Linus Walleij <[email protected]>
I think this patch is totally wrong and you have probably not tested it using pinctrl hogs.
pinctr_get() from self will *not work* unless the device is added to the list *first*.
Dropping this.
Yours,
Linus Walleij