testimage: Fix SDK extraction error handling
PATCH 1/1 testimage: Fix SDK extraction error handling
Currently if the SDK fails to extract, no error is shown and the test is marked as passed! Clearly this is incorrect, fix it to correctly raise an error.
Signed-off-by Richard Purdie <[email protected]>
meta/classes/testimage.bbclass +4 -1
@@ -379,7 +379,10 @@ def testsdk_main(d): sdktestdir = d.expand("${WORKDIR}/testimage-sdk/") bb.utils.remove(sdktestdir, True) bb.utils.mkdirhier(sdktestdir) - subprocess.call("cd %s; %s <<EOF\n./tc\nY\nEOF" % (sdktestdir, tcname), shell=True) + try: + subprocess.check_output("cd %s; %s <<EOF\n./tc\nY\nEOF" % (sdktestdir, tcname), shell=True) + except subprocess.CalledProcessError as e: + bb.fatal("Couldn't install the SDK:\n%s" % e.output) try: targets = glob.glob(d.expand(sdktestdir + "/tc/environment-setup-*"))