Skip to contentSkip to conversation

staging: speakup: Used kstrtoul instead of simple_strtoul

PATCH In review Aparna Karuthodi 2 participants 2 messages Sep 11, 2015 – Sep 12, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: speakup: Used kstrtoul instead of simple_strtoul

Used kstrtoul instead of simple_strtoul inorder to fix a warning detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is obsolete, use kstrtoul instead

---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
index 3708bc1..05de0b7 100644
@@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
 			continue;
 		}
 
-		index = simple_strtoul(cp, &temp, 10);
+		index = kstrtoul(cp, &temp, 10);
 		if (index > 255) {
 			rejected++;
 			cp = linefeed + 1;
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 26 lines · Aparna Karuthodi

Used kstrtoul instead of simple_strtoul inorder to fix a warning detected by checkpatch.
The warning is given below:
drivers/staging/speakup/kobjects.c:156: WARNING: simple_strtoul is obsolete, use kstrtoul instead

---
 drivers/staging/speakup/kobjects.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
index 3708bc1..05de0b7 100644
@@ -153,7 +153,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,
 			continue;
 		}
 
-		index = simple_strtoul(cp, &temp, 10);
+		index = kstrtoul(cp, &temp, 10);
 		if (index > 255) {
 			rejected++;
 			cp = linefeed + 1;
Signature · 1 line
1.7.9.5

Never send patches that you yourself did not at least test-build.