Skip to contentSkip to conversation

firmware: qcom: scm: Add function stubs for ARM64

PATCH In review Andy Gross 3 participants 3 messages Sep 11, 2015 Arm Qualcomm mailing list

lore
Share & tools
lore

Andy Gross

author
#0 lore raw

PATCH v2 1/1 firmware: qcom: scm: Add function stubs for ARM64

This patch adds stubs for the SCM functions exposed in the QCOM SCM API.

---
 drivers/firmware/Kconfig       |    8 +++++
 drivers/firmware/Makefile      |    3 +-
 drivers/firmware/qcom_scm-64.c |   63 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 drivers/firmware/qcom_scm-64.c
drivers/firmware/Kconfig +8 -0
index 99c69a3..72720eb 100644
@@ -136,6 +136,14 @@ config QCOM_SCM
 	bool
 	depends on ARM || ARM64
 
+config QCOM_SCM_32
+	def_bool y
+	depends on QCOM_SCM && ARM
+
+config QCOM_SCM_64
+	def_bool y
+	depends on QCOM_SCM && ARM64
+
 source "drivers/firmware/broadcom/Kconfig"
 source "drivers/firmware/google/Kconfig"
 source "drivers/firmware/efi/Kconfig"
drivers/firmware/Makefile +2 -1
index 4a4b897..73f841c 100644
@@ -12,7 +12,8 @@ obj-$(CONFIG_ISCSI_IBFT_FIND)	+= iscsi_ibft_find.o
 obj-$(CONFIG_ISCSI_IBFT)	+= iscsi_ibft.o
 obj-$(CONFIG_FIRMWARE_MEMMAP)	+= memmap.o
 obj-$(CONFIG_QCOM_SCM)		+= qcom_scm.o
-obj-$(CONFIG_QCOM_SCM)		+= qcom_scm-32.o
+obj-$(CONFIG_QCOM_SCM_64)	+= qcom_scm-64.o
+obj-$(CONFIG_QCOM_SCM_32)	+= qcom_scm-32.o
 CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
 
 obj-y				+= broadcom/
drivers/firmware/qcom_scm-64.c new file +63 -0

63 lines not on this page · raw message

Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
Acked-by on v2 1/1
#2 lore raw
In reply to Andy Gross
Quoted 16 lines · Andy Gross

This patch adds stubs for the SCM functions exposed in the QCOM SCM API.

---
 drivers/firmware/Kconfig       |    8 +++++
 drivers/firmware/Makefile      |    3 +-
 drivers/firmware/qcom_scm-64.c |   63 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 drivers/firmware/qcom_scm-64.c
drivers/firmware/Kconfig +0 -0
index 99c69a3..72720eb 100644
@@ -136,6 +136,14 @@ config QCOM_SCM
 	bool

drivers/firmware/Kconfig config QCOM_SCM · line 146

Quoted 10 lines
drivers/firmware/Kconfig +8 -0
 	depends on ARM || ARM64
 
+config QCOM_SCM_32
+	def_bool y
+	depends on QCOM_SCM && ARM
+
+config QCOM_SCM_64
+	def_bool y
+	depends on QCOM_SCM && ARM64
+

So if QCOM_SCM is selected by a consumer then the dependencies here will be met and the correct implementation will be chosen, as these aren't possible to deselect?

I guess that's an okay approach, so:

Regards,
Bjorn