libceph: advertise support for keepalive2
Ilya Dryomov
maintainerPATCH 1/1 libceph: advertise support for keepalive2
We are the client, but advertise keepalive2 anyway - for consistency, if nothing else. In the future the server might want to know whether its clients support keepalive2.
--- include/linux/ceph/ceph_features.h | 1 + 1 file changed, 1 insertion(+)
include/linux/ceph/ceph_features.h +1 -0
@@ -107,6 +107,7 @@ static inline u64 ceph_sanitize_features(u64 features)CEPH_FEATURE_OSDMAP_ENC | \CEPH_FEATURE_CRUSH_TUNABLES3 | \CEPH_FEATURE_OSD_PRIMARY_AFFINITY | \ +CEPH_FEATURE_MSGR_KEEPALIVE2 | \ CEPH_FEATURE_CRUSH_V4) #define CEPH_FEATURES_REQUIRED_DEFAULT \
Signature · 1 line
1.9.3
Quoted 3 lines · Ilya Dryomov
We are the client, but advertise keepalive2 anyway - for consistency, if nothing else. In the future the server might want to know whether its clients support keepalive2.
the kernel code still does fully support KEEPALIVE2 (it does not recognize CEPH_MSGR_TAG_KEEPALIVE2 tag). I think it's better to not advertise support for keepalive2.
Regards
Yan, Zheng
Quoted 25 lines
Signed-off-by Ilya Dryomov <[email protected]>--- include/linux/ceph/ceph_features.h | 1 + 1 file changed, 1 insertion(+)include/linux/ceph/ceph_features.h +1
-1@@ -107,6 +107,7 @@ static inline u64 ceph_sanitize_features(u64 features)CEPH_FEATURE_OSDMAP_ENC | \CEPH_FEATURE_CRUSH_TUNABLES3 | \CEPH_FEATURE_OSD_PRIMARY_AFFINITY | \ +CEPH_FEATURE_MSGR_KEEPALIVE2 | \ CEPH_FEATURE_CRUSH_V4) #define CEPH_FEATURES_REQUIRED_DEFAULT \ --1.9.3
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Ilya Dryomov
maintainerQuoted 8 lines · Zheng
Quoted 3 lines · Ilya Dryomov
We are the client, but advertise keepalive2 anyway - for consistency, if nothing else. In the future the server might want to know whether its clients support keepalive2.
the kernel code still does fully support KEEPALIVE2 (it does not recognize
CEPH_MSGR_TAG_KEEPALIVE2tag). I think it's better to not advertise support for keepalive2.
I guess by "does not recognize" you mean the kernel client knows how to write TAG_KEEPALIVE2, but not how to read it? The same is true about TAG_KEEPALIVE tag and the reverse (we can read, but can't write) is true about TAG_KEEPALIVE2_ACK.
What I'm getting at is the kernel client is the client, and so it doesn't need to know how to read keepalive bytes or write keepalive acks. The server however might want to know if its clients can send keepalive2 bytes and handle keepalive2 acks. Does this make sense?
Thanks,
Ilya
Yan, Zheng
Reviewed-byQuoted 15 lines · Ilya Dryomov
Quoted 8 lines · Zheng
Quoted 3 lines · Ilya Dryomov
We are the client, but advertise keepalive2 anyway - for consistency, if nothing else. In the future the server might want to know whether its clients support keepalive2.
the kernel code still does fully support KEEPALIVE2 (it does not recognize
CEPH_MSGR_TAG_KEEPALIVE2tag). I think it's better to not advertise support for keepalive2.I guess by "does not recognize" you mean the kernel client knows how to write
TAG_KEEPALIVE2, but not how to read it? The same is true aboutTAG_KEEPALIVEtag and the reverse (we can read, but can't write) is true aboutTAG_KEEPALIVE2_ACK.
Quoted 5 lines
What I'm getting at is the kernel client is the client, and so it doesn't need to know how to read keepalive bytes or write keepalive acks. The server however might want to know if its clients can send keepalive2 bytes and handle keepalive2 acks. Does this make sense?
Ok, it makes sense. thank you for explaination
Quoted 3 lines
Thanks,
Ilya