Skip to contentSkip to conversation

data_smart: Separate out update_overridevars into separate function

PATCH New Richard Purdie 1 participant 1 message Sep 16, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 data_smart: Separate out update_overridevars into separate function

No code changes, just refactoring to allow for functionality changes by moving things to a separate function.

bitbake/lib/bb/data_smart.py +6 -5
index 6754e7d..f245d99 100644
@@ -491,10 +491,8 @@ class DataSmart(MutableMapping):
             if '_' in var:
                 self._setvar_update_overrides(base, **loginfo)
 
-
             if base in self.overridevars:
-                self.overridevars.update(self.expandWithRefs(value, var).references)
-                self.internal_finalize(True)
+                self._setvar_update_overridevars(var, value)
             return
 
         if not var in self.dict:
@@ -527,8 +525,11 @@ class DataSmart(MutableMapping):
         self.varhistory.record(**loginfo)
 
         if var in self.overridevars:
-            self.overridevars.update(self.expandWithRefs(value, var).references)
-            self.internal_finalize(True)
+            self._setvar_update_overridevars(var, value)
+
+    def _setvar_update_overridevars(self, var, value):
+        self.overridevars.update(self.expandWithRefs(value, var).references)
+        self.internal_finalize(True)
 
     def _setvar_update_overrides(self, var, **loginfo):
         # aka pay the cookie monster