Skip to contentSkip to conversation

patch "usb: phy: phy-generic: Fix reset behaviour on legacy boot" added to usb-linus

PATCH [email protected] 1 participant 1 message Sep 17, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: phy: phy-generic: Fix reset behaviour on legacy boot

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From 762982db33b23029e98c844611e2e8beeb75bc0d Mon Sep 17 00:00:00 2001

From: Roger Quadros <[email protected]>
Date: Thu, 13 Aug 2015 13:28:42 +0300
Subject: usb: phy: phy-generic: Fix reset behaviour on legacy boot

The gpio-desc migration done in v4.0 caused a regression with legacy boots due to reversed reset logic. e.g. omap3-beagle USB host breaks on legacy boot.

Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that it matches the driver logic and pin behaviour.

Fixes e9f2cefb0cdc ("usb: phy: generic: migrate to gpio_desc")
Cc <[email protected]> # 4.0+
---
 drivers/usb/phy/phy-generic.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/phy/phy-generic.c +2 -1
index ec6ecd03269c..5320cb8642cb 100644
@@ -232,7 +232,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,
 		clk_rate = pdata->clk_rate;
 		needs_vcc = pdata->needs_vcc;
 		if (gpio_is_valid(pdata->gpio_reset)) {
-			err = devm_gpio_request_one(dev, pdata->gpio_reset, 0,
+			err = devm_gpio_request_one(dev, pdata->gpio_reset,
+						    GPIOF_ACTIVE_LOW,
 						    dev_name(dev));
 			if (!err)
 				nop->gpiod_reset =
Signature · 1 line
2.5.2