Skip to contentSkip to conversation

Patch "crypto: vmx - Fixing GHASH Key issue on little endian" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Sep 17, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

crypto: vmx - Fixing GHASH Key issue on little endian

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
crypto-vmx-fixing-ghash-key-issue-on-little-endian.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3c5f0ed78e976be705218cad62acf6a68e9d121e Mon Sep 17 00:00:00 2001

From: Leonidas Da Silva Barbosa <[email protected]>
Date: Fri, 14 Aug 2015 10:14:16 -0300
Subject: crypto: vmx - Fixing GHASH Key issue on little endian

From: Leonidas Da Silva Barbosa <[email protected]>

commit 3c5f0ed78e976be705218cad62acf6a68e9d121e upstream.

GHASH table algorithm is using a big endian key. In little endian machines key will be LE ordered. After a lxvd2x instruction key is loaded as it is, LE/BE order, in first case it'll generate a wrong table resulting in wrong hashes from the algorithm.

Bug affects only LE machines.
In order to fix it we do a swap for loaded key.

---
 drivers/crypto/vmx/ghashp8-ppc.pl |    6 ++++++
 1 file changed, 6 insertions(+)
drivers/crypto/vmx/ghashp8-ppc.pl +6 -0
@@ -61,6 +61,12 @@ $code=<<___;
 	mtspr		256,r0
 	li		r10,0x30
 	lvx_u		$H,0,r4			# load H
+	le?xor		r7,r7,r7
+	le?addi		r7,r7,0x8		# need a vperm start with 08
+	le?lvsr		5,0,r7
+	le?vspltisb	6,0x0f
+	le?vxor		5,5,6			# set a b-endian mask
+	le?vperm	$H,$H,$H,5
 
 	vspltisb	$xC2,-16		# 0xf0
 	vspltisb	$t0,1			# one

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/crypto-vmx-fixing-ghash-key-issue-on-little-endian.patch queue-4.2/crypto-vmx-fixing-aes-ctr-counter-bug.patch