Skip to contentSkip to conversation

netfilter: nf_log: wait for rcu grace after logger unregistration

PATCH New Pablo Neira Ayuso 1 participant 1 message Sep 17, 2015

Subsystems (2)
lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netfilter: nf_log: wait for rcu grace after logger unregistration

The nf_log_unregister() function needs to call synchronize_rcu() to make sure that the objects are not dereferenced anymore on module removal.

Fixes 5962815a6a56 ("netfilter: nf_log: use an array of loggers instead of list")

---
@Florian: I noticed this while reviewing your patch to fix the "zap all loggers" bug.

 net/netfilter/nf_log.c |    1 +
 1 file changed, 1 insertion(+)
net/netfilter/nf_log.c +1 -0
index a5ebd7d..a5d41df 100644
@@ -117,6 +117,7 @@ void nf_log_unregister(struct nf_logger *logger)
 			RCU_INIT_POINTER(loggers[i][logger->type], NULL);
 	}
 	mutex_unlock(&nf_log_mutex);
+	synchronize_rcu();
 }
 EXPORT_SYMBOL(nf_log_unregister);
 
Signature · 1 line
1.7.10.4