infiniband:core:Fix error handling in the function cm_lap_handler
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 5 lines
drivers/infiniband/core/cm.c +0
-0
drivers/infiniband/core/cm.c static int cm_lap_handler(struct cm_work *work) · line 2820
Quoted 10 lines
drivers/infiniband/core/cm.c +5
-1@@ -2812,7 +2812,12 @@ static int cm_lap_handler(struct cm_work *work)cm_init_av_for_response (work->port, work->mad_recv_wc->wc, work->mad_recv_wc->recv_buf.grh, &cm_id_priv->av); -cm_init_av_by_path (param->alternate_path, &cm_id_priv->alt_av); + ret =cm_init_av_by_path (param->alternate_path, &cm_id_priv- >alt_av); +if (ret) { +spin_unlock_irq (&cm_id_priv->lock); +cm_deref_id (cm_id_priv); + }
How can this be right? On a failure, we release the spinlock and the reference on the cm_id, then continue on with the processing?
Quoted 6 lines
drivers/infiniband/core/cm.c +1
-0+ ret =atomic_inc_and_test (&cm_id_priv->work_count);if (!ret)
list_add_tail(&work->list, &cm_id_priv->work_list);
--
2.1.4