Skip to contentSkip to conversation

webkitgtk: add REQUIRED_DISTRO_FEATURES

PATCH In review Martin Jansa 3 participants 7 messages Sep 21, 2015 – Sep 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 webkitgtk: add REQUIRED_DISTRO_FEATURES

* original webkit-gtk_1.8.3.bb recipe already had this, I don't know why it was removed when upgrading to 2.8.5

---
 meta/recipes-sato/webkit/webkitgtk_2.8.5.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/recipes-sato/webkit/webkitgtk_2.8.5.bb +4 -1
index 82d670d..859d0cb 100644
@@ -18,7 +18,10 @@ SRC_URI = "\
 SRC_URI[md5sum] = "df79991848a5096d3a75289ebce547ae"
 SRC_URI[sha256sum] = "3d1f0c534935f43fd74df90f2648fcee672d60f1f57a30fa557a77891ae04d20"
 
-inherit cmake lib_package pkgconfig perlnative pythonnative
+inherit cmake lib_package pkgconfig perlnative pythonnative distro_features_check
+
+# depends on libxt
+REQUIRED_DISTRO_FEATURES = "x11"
 
 DEPENDS = "zlib enchant libsoup-2.4 curl libxml2 cairo libxslt libxt libidn gnutls \
            gtk+ gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
Signature · 1 line
2.5.1
#1 lore raw
Quoted 2 lines · Martin Jansa

* original webkit-gtk_1.8.3.bb recipe already had this, I don't know why it was removed when upgrading to 2.8.5

It was removed because I couldn't figure out why it's actually needed. What is the scenario?

Regards,
Alex

#2 lore raw
Quoted 9 lines · Alexander Kanavin
Quoted 3 lines · Martin Jansa

* original webkit-gtk_1.8.3.bb recipe already had this, I don't know why it was removed when upgrading to 2.8.5

It was removed because I couldn't figure out why it's actually needed. What is the scenario?

Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need or use X") and build webkitgtk. webkitgtk depends on libxt which depends on libx11 which then refuses to build because you explicitly said you didn't want X.

We're adding required_distro_feature annotations as required so that world builds without X11 enabled still work by skipping the recipes instead of failing to build.

Ross

#3 lore raw
Quoted 8 lines

Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need or use X") and build webkitgtk. webkitgtk depends on libxt which depends on libx11 which then refuses to build because you explicitly said you didn't want X.

We're adding required_distro_feature annotations as required so that world builds without X11 enabled still work by skipping the recipes instead of failing to build.

But this means you need to add this to every recipe that directly or indirectly depends on libx11. Which is crazy awkward and error-prone.

Why can't the tools figure out which recipes should be excluded from builds without explicit annotations?

Alex

#4 lore raw
Quoted 5 lines · On Tue, Sep 22, 2015 at 02:12:36PM +0300, [email protected]…
Quoted 5 lines

Remove x11 from DISTRO_FEATURES ("I'm building a product that doesn't need or use X") and build webkitgtk. webkitgtk depends on libxt which depends on libx11 which then refuses to build because you explicitly said you didn't want X.

Quoted 7 lines
Quoted 3 lines

We're adding required_distro_feature annotations as required so that world builds without X11 enabled still work by skipping the recipes instead of failing to build.

But this means you need to add this to every recipe that directly or indirectly depends on libx11. Which is crazy awkward and error-prone.

And was already done:
http://git.openembedded.org/openembedded-core/commit/?id=78d269fa9a586e24ef058ba5315c696f15935f56
http://git.openembedded.org/openembedded-core/commit/?id=bc4d051c2fa56acb0479330b4342a39396de30d4
http://git.openembedded.org/openembedded-core/commit/?id=8764282a06fa5f7571c479a5b3b35c7baaad241f
http://git.openembedded.org/openembedded-core/commit/?id=fda535d5b5239b091c79e957f68a45d4eab0ab5d
http://git.openembedded.org/openembedded-core/commit/?id=1cf0245344ce272e7330cfe1b04a0ed7bd18e8f5
http://git.openembedded.org/openembedded-core/commit/?id=fa1d9b518708103b0b2e259aa78f8dd694cfc0d6

and it's not so error-prone, just call "bitbake world" in DISTRO without x11 in DISTRO_FEATURES and fix all the ERROR: messages at the beginning.

Quoted 2 lines

Why can't the tools figure out which recipes should be excluded from builds without explicit annotations?

See discussion around this change on ML and please don't remove stuff just because you don't know/remember why it was added without at least using "git blame" to read commit which introduced it.

Thanks

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#5 lore raw
Quoted 6 lines
Quoted 2 lines

Why can't the tools figure out which recipes should be excluded from builds without explicit annotations?

See discussion around this change on ML and please don't remove stuff just because you don't know/remember why it was added without at least using "git blame" to read commit which introduced it.

Fair enough. What about adding new recipes? How is one supposed to figure out whether there are required distro features to list?

Alex

#6 lore raw
In reply to Alexander Kanavin
Quoted 6 lines · Alexander Kanavin
Quoted 2 lines · Martin Jansa

* original webkit-gtk_1.8.3.bb recipe already had this, I don't know why it was removed when upgrading to 2.8.5

It was removed because I couldn't figure out why it's actually needed. What is the scenario?

DISTROs without x11 shouldn't try to build webkitgtk, because it will fail with ugly error message about libxt not being available.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]