Fix: glib >= 2.32 required for g_hash_table_contains() in lib/values.c
A message that is not in the archive (sent off-list or not yet received): [email protected]
We could change the uses of g_hash_table_contains() to use g_hash_table_find() (which was present in 2.4).
However, at this point I wouldn't feel too bad bumping the dependency to 2.32 in BT 2.0 considering glib 2.32 was released in March 2012 and was, AFAICT, shipped in Ubuntu 12.04... No strong opinion.
Mathieu, thoughts?
Jérémie
Quoted 20 lines · Michael Jeanson
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.ac +1
-2@@ -54,7 +54,7 @@ if test ! -f "$srcdir/formats/ctf/metadata/ctf-lexer.c"; then fi -AM_PATH_GLIB_2_0(2.22.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule) +AM_PATH_GLIB_2_0(2.32.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule) # Checks for typedefs, structures, and compiler characteristics. AC_C_INLINE --1.9.1
Signature · 8 lines
Jérémie Galarneau EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
A message that is not in the archive (sent off-list or not yet received): CA+jJMxtE38xCqs_XZaMCErKsn4Li2MgNkceouBHXUn+aRSp__w@mail.gmail.com
Quoted 8 lines · ----- On Sep 21, 2015, at 5:15 PM, Jeremie Galarneau…
We could change the uses of
g_hash_table_contains()to useg_hash_table_find()(which was present in 2.4).However, at this point I wouldn't feel too bad bumping the dependency to 2.32 in BT 2.0 considering glib 2.32 was released in March 2012 and was, AFAICT, shipped in Ubuntu 12.04... No strong opinion.
Mathieu, thoughts?
SLES 11 sp3 still has glib 2.22
Quoted 33 lines
Jérémie
Quoted 17 lines · Michael Jeanson
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.ac +1
-1@@ -54,7 +54,7 @@ if test ! -f "$srcdir/formats/ctf/metadata/ctf-lexer.c"; then fi -AM_PATH_GLIB_2_0(2.22.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule) +AM_PATH_GLIB_2_0(2.32.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)Quoted 5 lines
# Checks for typedefs, structures, and compiler characteristics.
AC_C_INLINE
--
1.9.1--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
Signature · 8 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 8 lines · ----- On Sep 21, 2015, at 5:15 PM, Jeremie Galarneau…
We could change the uses of
g_hash_table_contains()to useg_hash_table_find()(which was present in 2.4).However, at this point I wouldn't feel too bad bumping the dependency to 2.32 in BT 2.0 considering glib 2.32 was released in March 2012 and was, AFAICT, shipped in Ubuntu 12.04... No strong opinion.
Mathieu, thoughts?
SLES 11 SP3 has 2.22.5:
I'd keep the current old dep if possible.
Thanks,
Mathieu
Quoted 33 lines
Jérémie
Quoted 17 lines · Michael Jeanson
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.ac +1
-1@@ -54,7 +54,7 @@ if test ! -f "$srcdir/formats/ctf/metadata/ctf-lexer.c"; then fi -AM_PATH_GLIB_2_0(2.22.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule) +AM_PATH_GLIB_2_0(2.32.0, ,AC_MSG_ERROR([glib is required in order to compile BabelTrace - download it from ftp://ftp.gtk.org/pub/gtk]) , gmodule)Quoted 5 lines
# Checks for typedefs, structures, and compiler characteristics.
AC_C_INLINE
--
1.9.1--
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com
Signature · 8 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev