Skip to contentSkip to conversation

patch "usb: xhci: lock mutex on xhci_stop" added to usb-linus

PATCH [email protected] 1 participant 1 message Sep 22, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: xhci: lock mutex on xhci_stop

to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

Quoted 1 line

From 85ac90f8953a58f6a057b727bc9db97721e3fb8e Mon Sep 17 00:00:00 2001

From: Roger Quadros <[email protected]>
Date: Mon, 21 Sep 2015 17:46:12 +0300
Subject: usb: xhci: lock mutex on xhci_stop

Else it races with xhci_setup_device

---
 drivers/usb/host/xhci.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/host/xhci.c +4 -0
index 6b0f4a47e402..f560c4100e2f 100644
@@ -677,8 +677,11 @@ void xhci_stop(struct usb_hcd *hcd)
 	u32 temp;
 	struct xhci_hcd *xhci = hcd_to_xhci(hcd);
 
+	mutex_lock(&xhci->mutex);
+
 	if (!usb_hcd_is_primary_hcd(hcd)) {
 		xhci_only_stop_hcd(xhci->shared_hcd);
+		mutex_unlock(&xhci->mutex);
 		return;
 	}
 
@@ -717,6 +720,7 @@ void xhci_stop(struct usb_hcd *hcd)
 	xhci_dbg_trace(xhci, trace_xhci_dbg_init,
 			"xhci_stop completed - status = %x",
 			readl(&xhci->op_regs->status));
+	mutex_unlock(&xhci->mutex);
 }
 
 /*
Signature · 1 line
2.5.3