Skip to contentSkip to conversation

Patch "powerpc/pseries: Fix corrupted pdn list" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Sep 23, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

powerpc/pseries: Fix corrupted pdn list

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
powerpc-pseries-fix-corrupted-pdn-list.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 590c7567a2895f939525ead57b0334c6d47986f0 Mon Sep 17 00:00:00 2001

From: Gavin Shan <[email protected]>
Date: Thu, 27 Aug 2015 14:12:36 +1000
Subject: powerpc/pseries: Fix corrupted pdn list

From: Gavin Shan <[email protected]>

commit 590c7567a2895f939525ead57b0334c6d47986f0 upstream.

Commit cca87d30 ("powerpc/pci: Refactor pci_dn") introduced pdn list for SRIOV VFs. It means the pdn is be put into the child list of its parent pdn when the pdn is created. When doing PCI hot unplugging on pSeries, the PCI device node as well as its pdn are released through procfs entry "powerpc/ofdt". Some one else grabs the memory chunk of the pdn and update it accordingly. At the same time, the pdn is still tracked in the child list of parent pdn. It leads to corrupted child list in the parent pdn.

This fixes above issue by removing the pdn from the child list of its parent pdn when the device node is detached from the system. Note the pdn is free'd when the device node is released if the device node is dynamic one. Otherwise, the device node as well as the pdn won't be released.

Fixes cca87d30 ("powerpc/pci: Refactor pci_dn")
---
 arch/powerpc/platforms/pseries/setup.c |    5 +++++
 1 file changed, 5 insertions(+)
arch/powerpc/platforms/pseries/setup.c +5 -0
@@ -268,6 +268,11 @@ static int pci_dn_reconfig_notifier(stru
 			eeh_dev_init(PCI_DN(np), pci->phb);
 		}
 		break;
+	case OF_RECONFIG_DETACH_NODE:
+		pci = PCI_DN(np);
+		if (pci)
+			list_del(&pci->list);
+		break;
 	default:
 		err = NOTIFY_DONE;
 		break;

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/powerpc-eeh-probe-after-unbalanced-kref-check.patch queue-4.2/powerpc-eeh-fix-fenced-phb-caused-by-eeh_slot_error_detail.patch queue-4.2/powerpc-pseries-fix-corrupted-pdn-list.patch