Skip to contentSkip to conversation

gcc-shared-source: Set empty SRC_URI

PATCH In review Richard Purdie 2 participants 3 messages Sep 23, 2015 – Sep 25, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-shared-source: Set empty SRC_URI

gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch tasks, the other gcc recipes then depend on this.

This approach has been creating some confusion for tools like the archiver. The simplest way to signal to these processes that there is no source is to empty SRC_URI at the same time we disable the other tasks.

meta/recipes-devtools/gcc/gcc-shared-source.inc +2 -0
index 9acffb1..aac4b49 100644
@@ -5,5 +5,7 @@ do_fetch[noexec] = "1"
 deltask do_unpack
 deltask do_patch
 
+SRC_URI = ""
+
 do_configure[depends] += "gcc-source-${PV}:do_preconfigure"
 do_populate_lic[depends] += "gcc-source-${PV}:do_unpack"
#1 lore raw
Quoted 8 lines · Richard Purdie

gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch tasks, the other gcc recipes then depend on this.

This approach has been creating some confusion for tools like the archiver. The simplest way to signal to these processes that there is no source is to empty SRC_URI at the same time we disable the other tasks.

This has broken the upstream version check for the gcc recipes, which was working fine before:

http://packages.yoctoproject.org/

Alex

#2 lore raw
Quoted 8 lines · Alexander Kanavin
Quoted 8 lines

gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch tasks, the other gcc recipes then depend on this.

This approach has been creating some confusion for tools like the archiver.
The simplest way to signal to these processes that there is no source is to empty SRC_URI at the same time we disable the other tasks.

Quoted 6 lines
Quoted 1 line

This has broken the upstream version check for the gcc recipes, which was working fine before:

http://packages.yoctoproject.org/

Actually, maybe the problem is not with this patch, but with the upstream version checker that defaults to 1.0 when the SRC_URI is empty or points to a local file. In that case, it should simply set the upstream version to the version of the recipe itself. I'll file a bug.

Alex