phy: sun4i-usb: Use devm_gpiod_get_optional for optional GPIOs
Subsystems (2)
PATCH RESEND 1/1 phy: sun4i-usb: Use devm_gpiod_get_optional for optional GPIOs
Both data->id_det_gpio and data->vbus_det_gpio are optional, so use devm_gpiod_get_optional for them.
Signed-off-by Axel Lin <[email protected]>
Reviewed-by Hans de Goede <[email protected]>
---
This patch was sent on https://lkml.org/lkml/2015/8/21/177
drivers/phy/phy-sun4i-usb.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-)
drivers/phy/phy-sun4i-usb.c +9 -13
@@ -551,19 +551,15 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)if (IS_ERR (data->base))return PTR_ERR (data->base); - data->id_det_gpio =devm_gpiod_get (dev,"usb0_id_det" ,GPIOD_IN ); -if (IS_ERR (data->id_det_gpio)) { -if (PTR_ERR (data->id_det_gpio) == -EPROBE_DEFER ) -return -EPROBE_DEFER ; - data->id_det_gpio =NULL ; - } - - data->vbus_det_gpio =devm_gpiod_get (dev,"usb0_vbus_det" ,GPIOD_IN ); -if (IS_ERR (data->vbus_det_gpio)) { -if (PTR_ERR (data->vbus_det_gpio) == -EPROBE_DEFER ) -return -EPROBE_DEFER ; - data->vbus_det_gpio =NULL ; - } + data->id_det_gpio =devm_gpiod_get_optional (dev,"usb0_id_det" , +GPIOD_IN ); +if (IS_ERR (data->id_det_gpio)) +return PTR_ERR (data->id_det_gpio); + + data->vbus_det_gpio =devm_gpiod_get_optional (dev,"usb0_vbus_det" , +GPIOD_IN ); +if (IS_ERR (data->vbus_det_gpio)) +return PTR_ERR (data->vbus_det_gpio);if (of_find_property (np,"usb0_vbus_power-supply" ,NULL )) { data->vbus_power_supply = devm_power_supply_get_by_phandle(dev,
Signature · 1 line
2.1.0
Hi,
Quoted 5 lines · Axel Lin
Both
data->id_det_gpioanddata->vbus_det_gpioare optional, so usedevm_gpiod_get_optionalfor them.Signed-off-by Axel Lin <[email protected]>Reviewed-by Hans de Goede <[email protected]>
merged this to linux-phy tree.
Thanks
Kishon
Quoted 40 lines
---
This patch was sent on https://lkml.org/lkml/2015/8/21/177drivers/phy/phy-sun4i-usb.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-)drivers/phy/phy-sun4i-usb.c +9
-13@@ -551,19 +551,15 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)if (IS_ERR (data->base))return PTR_ERR (data->base); - data->id_det_gpio =devm_gpiod_get (dev,"usb0_id_det" ,GPIOD_IN ); -if (IS_ERR (data->id_det_gpio)) { -if (PTR_ERR (data->id_det_gpio) == -EPROBE_DEFER ) -return -EPROBE_DEFER ; - data->id_det_gpio =NULL ; - } - - data->vbus_det_gpio =devm_gpiod_get (dev,"usb0_vbus_det" ,GPIOD_IN ); -if (IS_ERR (data->vbus_det_gpio)) { -if (PTR_ERR (data->vbus_det_gpio) == -EPROBE_DEFER ) -return -EPROBE_DEFER ; - data->vbus_det_gpio =NULL ; - } + data->id_det_gpio =devm_gpiod_get_optional (dev,"usb0_id_det" , +GPIOD_IN ); +if (IS_ERR (data->id_det_gpio)) +return PTR_ERR (data->id_det_gpio); + + data->vbus_det_gpio =devm_gpiod_get_optional (dev,"usb0_vbus_det" , +GPIOD_IN ); +if (IS_ERR (data->vbus_det_gpio)) +return PTR_ERR (data->vbus_det_gpio);if (of_find_property (np,"usb0_vbus_power-supply" ,NULL )) { data->vbus_power_supply = devm_power_supply_get_by_phandle(dev,